Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specificAssetIds in detailsCard #113

Merged
merged 7 commits into from
Dec 10, 2024

Conversation

seicke
Copy link
Member

@seicke seicke commented Nov 19, 2024

Description of Changes

specificAssetIds

Maybe the semanticIds of the specificAssetIds should be hided. I'm not sure.

AAS Files Used for Testing

aas-gui.zip

@seicke seicke marked this pull request as ready for review November 19, 2024 12:04
@seicke seicke requested a review from aaronzi November 19, 2024 12:04
@aaronzi
Copy link
Member

aaronzi commented Dec 10, 2024

Thank you for this PR. I would suggest moving the (specific) AssetIds to its own component. Could you also have a look at the merge conflicts so that I will be able to merge this PR.

@aaronzi aaronzi merged commit 3fffde3 into eclipse-basyx:main Dec 10, 2024
2 checks passed
@seicke seicke deleted the specific-asset-ids branch December 11, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants