Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves endpoint handling of descriptors #60

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

aaronzi
Copy link
Member

@aaronzi aaronzi commented Oct 17, 2024

Improves endpoint handling of descriptors

Description of Changes

This PR improves the extraction of the right href from the endpoint of an AAS/Submodel descriptors.
It follows the API specifications in regards to extracting the right endpoint based on the interface-shortName (see screenshot)

image

Related Issue

Closes #57

Additional Information

This fix makes it possible to use the BaSyx AAS Web UI as a frontend for the FA³ST service + registry.
For more details have a look at the issue on the FA³ST repo:
FraunhoferIOSB/FAAAST-Service#914

Copy link
Member

@seicke seicke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronzi aaronzi merged commit 3d27d68 into eclipse-basyx:main Oct 29, 2024
2 checks passed
@aaronzi aaronzi deleted the fix-endpoint-selection branch October 29, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Use BaSyx AAS Web UI with FA³ST Service/Registry
2 participants