Fixes indefinite loading of AAS Treeview after invalid selection #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seicke
suggested changes
Oct 29, 2024
There was a problem hiding this comment.
I think the loading state should also be reset for retrieving Submodel References in SubmodelList.vue (AAS Viewer)
|
Good point, I totally overlooked that. Thank you very much for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes indefinite loading state of AAS Treeview after invalid AAS selection
Description of Changes
This PR adds missing resets of the loading state of the treeview in the cases were an error is catched or a validation was not successfull.
Related Issue
Closes #20