Fix for "[BUG] Jumping to referenced element not working properly Fixes #46" #75

seicke · 2024-10-31T12:23:16Z

Description of Changes

Closes #46

seicke · 2024-10-31T12:30:25Z

In SubmodelElementHandling the path of the SME jumping to is generated with the help of URLEncode. Because of BASE64 encoding URLEncode provides URLs with "%3D" instead of "="
The pathes of SMEs in the submodelData (fetched from the Repositorty) do not contain such "%3D"

The result is a nonmatching of the pathes in

Line 338 in e5bff9c

if (element.path === updatedNode.path) {

Line 364 in e5bff9c

if (element.path == path) {

Fix

a9a8ae2

seicke marked this pull request as ready for review October 31, 2024 12:31

seicke requested a review from aaronzi October 31, 2024 12:31

aaronzi approved these changes Oct 31, 2024

View reviewed changes

aaronzi merged commit 282f95a into eclipse-basyx:main Oct 31, 2024
2 checks passed

seicke deleted the seicke/issue46 branch October 31, 2024 13:48

seicke restored the seicke/issue46 branch November 4, 2024 07:42

seicke deleted the seicke/issue46 branch November 4, 2024 07:42