Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More V3 work #17

Merged

Conversation

tobijk2
Copy link

@tobijk2 tobijk2 commented Sep 12, 2023

  • Size-constrained strings for Identifier and the new LabelType
  • Adaptation of the specificAssetId

This will be used in coming commits

The new V3 Metamodel imposes restrictions on string min and max length. We have
to follow those to be complient, thus we need to constrain our string to the
imposed sizes. This class is introduced to fulfill the need for constrained
strings.

Strings constrained by the new standard are (min/max characters):
Identifier: min: 1, max: 2000
LabelType: min: 1, max 64

Signed-off-by: Tobias Klausmann<[email protected]>
We have a lower and upper limit to follow:
1 <> 2000

Signed-off-by: Tobias Klausmann <[email protected]>
Use MinMaxString as we have to follow size constraints:
1 <> 64

This will be used in the SpecificAssetId and Entity

Signed-off-by: Tobias Klausmann <[email protected]>
@tobijk2 tobijk2 force-pushed the development_v2_klausmannt branch from 4c62c05 to 962ddb6 Compare September 13, 2023 11:58
Adapt properties to the new specification

As the types are final, rename them according to the new specification

Signed-off-by: Tobias Klausmann <[email protected]>
@tobijk2 tobijk2 force-pushed the development_v2_klausmannt branch from 962ddb6 to be9be55 Compare September 13, 2023 12:14
@IESE-T3 IESE-T3 merged commit 621b971 into eclipse-basyx:development_v2 Sep 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants