Changes for review comments to use IOUtils for cheking the inputstrea…

…m data Signed-off-by: Chaithra Kandur Bhagavanthaiah <[email protected]>
eclipse-basyx · Sep 19, 2023 · 393d5be · 393d5be
1 parent bf03b58
commit 393d5be
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/basyx.aasxfileserver/basyx.aasxfileserver-core/pom.xml b/basyx.aasxfileserver/basyx.aasxfileserver-core/pom.xml
@@ -21,5 +21,10 @@
 			<groupId>org.eclipse.digitaltwin.aas4j</groupId>
 			<artifactId>model</artifactId>
 		</dependency>
+		<dependency>
+    		<groupId>commons-io</groupId>
+    		<artifactId>commons-io</artifactId>
+    		<scope>test</scope>    		
+		</dependency>
 	</dependencies>
 </project>
diff --git a/.../src/test/java/org/eclipse/digitaltwin/basyx/aasxfileserver/core/AasxFileServerSuite.java b/.../src/test/java/org/eclipse/digitaltwin/basyx/aasxfileserver/core/AasxFileServerSuite.java
@@ -29,12 +29,14 @@
 import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
 
+import java.io.IOException;
 import java.io.InputStream;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collection;
 import java.util.List;
 
+import org.apache.commons.io.IOUtils;
 import org.eclipse.digitaltwin.basyx.aasxfileserver.AasxFileServer;
 import org.eclipse.digitaltwin.basyx.aasxfileserver.PackageDescription;
 import org.eclipse.digitaltwin.basyx.core.exceptions.ElementDoesNotExistException;
@@ -97,13 +99,14 @@ public void updateNonExistingAASXByPackageId() {
 	}	
 
 	@Test
-	public void getAASXByPackageId() throws ElementDoesNotExistException {
+	public void getAASXByPackageId() throws ElementDoesNotExistException, IOException {
 
 		AasxFileServer server = getAasxFileServer();
 		PackageDescription packageDescription = DummyAasxFileServerFactory.createFirstDummyAASXPackage(server);			
-		InputStream actualValue = server.getAASXByPackageId(packageDescription.getPackageId());		
+		InputStream actualValue = server.getAASXByPackageId(packageDescription.getPackageId());	
+		InputStream expectedValue = AasxFileServerSuiteHelper.FIRST_FILE;		
 
-		assertEquals(AasxFileServerSuiteHelper.FIRST_FILE, actualValue);		
+		IOUtils.contentEquals(expectedValue, actualValue);
 	}
 
 	@Test