Change status code for thumbnail upload to 204 (no_content) (#426)

* Change status code for thumbnail upload to 204 (no_content). refs #359 * Trigger build * Update authorization tests and alter the status code refs #359
eclipse-basyx · Sep 11, 2024 · 7b01e4c · 7b01e4c
1 parent 51e84c6
commit 7b01e4c
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/...se/digitaltwin/basyx/aasrepository/feature/authorization/TestAuthorizedAasRepository.java b/...se/digitaltwin/basyx/aasrepository/feature/authorization/TestAuthorizedAasRepository.java
@@ -575,7 +575,7 @@ public void setThumbnailWithCorrectRoleAndPermission() throws IOException {
 		String accessToken = getAccessToken(DummyCredentialStore.BASYX_UPDATER_CREDENTIAL);
 
 		CloseableHttpResponse retrievalResponse = setThumbnailToAasWithAuthorization(SPECIFIC_SHELL_ID, accessToken);
-		assertEquals(HttpStatus.OK.value(), retrievalResponse.getCode());
+		assertEquals(HttpStatus.NO_CONTENT.value(), retrievalResponse.getCode());
 
 		deleteElementWithAuthorization(BaSyxHttpTestUtils.getThumbnailAccessURL(createAasRepositoryUrl(aasRepositoryBaseUrl), SPECIFIC_SHELL_ID), getAccessToken(DummyCredentialStore.ADMIN_CREDENTIAL));
 	}
@@ -585,7 +585,7 @@ public void setThumbnailWithCorrectRoleAndSpecificAasPermission() throws IOExcep
 		String accessToken = getAccessToken(DummyCredentialStore.BASYX_UPDATER_TWO_CREDENTIAL);
 
 		CloseableHttpResponse retrievalResponse = setThumbnailToAasWithAuthorization(SPECIFIC_SHELL_ID, accessToken);
-		assertEquals(HttpStatus.OK.value(), retrievalResponse.getCode());
+		assertEquals(HttpStatus.NO_CONTENT.value(), retrievalResponse.getCode());
 
 		deleteElementWithAuthorization(BaSyxHttpTestUtils.getThumbnailAccessURL(createAasRepositoryUrl(aasRepositoryBaseUrl), SPECIFIC_SHELL_ID), getAccessToken(DummyCredentialStore.ADMIN_CREDENTIAL));
 	}

diff --git a/...java/org/eclipse/digitaltwin/basyx/aasrepository/http/AasRepositoryApiHTTPController.java b/...java/org/eclipse/digitaltwin/basyx/aasrepository/http/AasRepositoryApiHTTPController.java
@@ -204,7 +204,7 @@ public ResponseEntity<Void> putThumbnailAasRepository(Base64UrlEncodedIdentifier
 			fileInputstream = file.getInputStream();
 			aasRepository.setThumbnail(aasIdentifier.getIdentifier(), fileName, file.getContentType(), fileInputstream);
 			closeInputStream(fileInputstream);
-			return new ResponseEntity<Void>(HttpStatus.OK);
+			return new ResponseEntity<Void>(HttpStatus.NO_CONTENT);
 		} catch (IOException e) {
 			closeInputStream(fileInputstream);
 			return new ResponseEntity<Void>(HttpStatus.INTERNAL_SERVER_ERROR);

diff --git a/...rc/test/java/org/eclipse/digitaltwin/basyx/aasrepository/http/AasRepositoryHTTPSuite.java b/...rc/test/java/org/eclipse/digitaltwin/basyx/aasrepository/http/AasRepositoryHTTPSuite.java
@@ -336,7 +336,7 @@ public void uploadThumbnailToShell() throws IOException {
 		createDummyAasOnServer(getAas1JSONString());
 		CloseableHttpResponse getThumbnailResponse = uploadThumbnail(dummyAasId);
 
-		assertEquals(HttpStatus.OK.value(), getThumbnailResponse.getCode());
+		assertEquals(HttpStatus.NO_CONTENT.value(), getThumbnailResponse.getCode());
 
 		getThumbnailResponse.close();
 	}

diff --git a/...src/test/java/org/eclipse/digitaltwin/basyx/aasrepository/http/TestAasRepositoryHTTP.java b/...src/test/java/org/eclipse/digitaltwin/basyx/aasrepository/http/TestAasRepositoryHTTP.java
@@ -38,7 +38,7 @@
  * {@link AasRepository} HTTP/REST API
  * 
  * @author schnicke, danish
- *
+ * 
  */
 public class TestAasRepositoryHTTP extends AasRepositoryHTTPSuite {
 	private static final PaginationInfo NO_LIMIT_PAGINATION_INFO = new PaginationInfo(0, null);