-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add healthcheck in components dockerfile #104
Add healthcheck in components dockerfile #104
Conversation
Integrating the healthcheck directly in the container is a good idea. However, polling the /shells etc. endpoint might create a high load on backend etc. Can you update the PR to use the explicit health endpoint? |
I will do that, but before that, I need to know if management path should be configurable or not. The latest aas environment docker
So it seems |
Thanks for pointing this out, we missed updating the documentation for this. I'm currently not aware of a use case where reconfiguring the health endpoint's location would make sense in our contexts. Thus, you can assume it to always be at /actuator/health |
Hi @mhrimaz, any update on this? Is this still of relevance for you? |
use `/actuator/health` as health endpoint
set actuator config to default to keep docker images compatible
Healthcheck for AASXFileServer
8f146e5
to
8ae315f
Compare
@FrankSchnicke should be fine now. Also check #138 if you need base image bump. |
Thanks a lot for this PR. If you mark it as "ready for review", I will merge it. |
With the integrated healthcheck, it is easier to determine container health.
As further addition it would be nice to bump the jdk base image to eclipse temurin jdk 17.
What do you think? @FrankSchnicke