Adds AAS Discovery Service #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Zai Müller-Zhang <[email protected]>
…feature/discovery-service
- Refactors InMemory code and TCK - Refactors Aas Discovery component - Refactors AAS Discovery Service Backend InMemory - Refactors AAS Discovery Service Backend InMemory - Refactors AAS Discovery Service Backend MongoDB - Refactors AAS Discovery Service core - Refactors AAS Discovery Service http - Updates Readme - Refactors TCK name Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
jannisjung
reviewed
Oct 24, 2023
| @Autowired(required = false) | ||
| public MongoDBAasDiscoveryServiceFactory(MongoTemplate mongoTemplate, | ||
| @Value("${basyx.aasdiscoveryservice.mongodb.collectionName:aasdiscovery-service}") String collectionName, | ||
| @Value("${basyx.aasdiscserv.name:aas-discovery-service}") String aasDiscoveryServiceName) { |
There was a problem hiding this comment.
why are we using different names here?, basyx.aasdiscoveryservice... and basyx.aasdiscserv... -> naming should be kept consistent
There was a problem hiding this comment.
Thanks for pointing this out.
We renamed it to basyx.aasdiscoveryservice.name for consistency.
* Replaces Sys.out with logger * Refactors stream-API-Statement to a smaller footprint Signed-off-by: Jannis Jung <[email protected]>
* applies BaSyx formatter * adds trailing empty line to poms Signed-off-by: Jannis Jung <[email protected]>
- Renames property basyx.aasdiscserv.name to basyx.aasdiscoveryservice.name Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]> Co-authored-by: Zai Müller-Zhang <[email protected]>
jannisjung
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mohammad Ghazanfar Ali Danish [email protected]
Co-authored-by: Zai Müller-Zhang [email protected]