Migration to spring3/jakarta/java17 #139
Conversation
|
Closes #113 |
# Conflicts: # basyx.aasenvironment/basyx.aasenvironment.component/Dockerfile # basyx.aasrepository/basyx.aasrepository.component/Dockerfile # basyx.conceptdescriptionrepository/basyx.conceptdescriptionrepository.component/Dockerfile # basyx.submodelrepository/basyx.submodelrepository.component/Dockerfile
| @@ -49,5 +50,13 @@ | |||
| <groupId>org.springframework.boot</groupId> | |||
| <artifactId>spring-boot-starter-data-mongodb</artifactId> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
I think these two dependencies are unnecessary.
I build it without these and it is successful.
What do you think?
| <groupId>jakarta.validation</groupId> | ||
| <artifactId>jakarta.validation-api</artifactId> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
I think this dependency is unnecessary.
I build it without this and it is successful.
What do you think?
There was a problem hiding this comment.
Now it's required - for e.g. Base64UrlEncodedIdentifierSizeValidator
| @@ -89,5 +89,10 @@ | |||
| <classifier>tests</classifier> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
I think this dependency is unnecessary. Because of this no tests are running as tests are in JUnit4.
I build it without this and it is successful and also tests are running now.
What do you think?
pom.xml
Outdated
| <artifactId>surefire-junit47</artifactId> | ||
| <version>3.1.2</version> | ||
| </dependency> | ||
| <!-- <dependency>--> |
There was a problem hiding this comment.
This could be removed if it is not required.
|
@mdanish98 I can't activate the kafka modules, since they aren't spring3 ready - in their current configuration. @FrankSchnicke and @geso02 agreed on this and @geso02 will contribute related changes as soon as this pull request is merged. |
|
@alexgordtop yes sure I am removing those remarks. |
|
Thanks a lot! |
No description provided.