Implements AASX File Integration in Submodel Repository #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds logging for file deletion due to invalid path in InMemorySubmodelRepository
- Replaces InputStreamResource with FileSystemResource in SubmodelRepositoryApiHTTPController
(Fixes file appearance issue when requesting over HTTP )
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
|
|
||
| File actualFile = submodelRepo.getFileByPathSubmodel("http://i40.customer.com/type/1/1/1A7B62B529F19152", "OperatingManual.DigitalFile_PDF"); | ||
|
|
||
| assertEquals(expectedFileExtension, getExtension(actualFile.getName())); |
There was a problem hiding this comment.
Why not use assertFileContents here?
| @@ -0,0 +1,116 @@ | |||
| package org.eclipse.digitaltwin.basyx.aasenvironment; | |||
There was a problem hiding this comment.
Missing license header
| @@ -0,0 +1,165 @@ | |||
| package org.eclipse.digitaltwin.basyx.aasenvironment; | |||
There was a problem hiding this comment.
Missing license header
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
|
Approved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mohammad Ghazanfar Ali Danish [email protected]