Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven Docker Build improvements #151

Conversation

oalagtash
Copy link
Contributor

Included changes:

  • One mvn deploy command to deploy all docker images in the repository.
  • Unified and simplified docker-maven-plugin configuration.
  • Allow having different namespace and username.
  • Added missing docker healthcheck.
  • Changed wrong java version of registry-aas from 11 to 17.

@FrankSchnicke
Copy link
Contributor

Thanks a lot for your contribution! However, the Eclipse Contributer Agreement check is failing. Did you link your GitHub account with your Eclipse account? Are you using the same mails?

@oalagtash
Copy link
Contributor Author

oalagtash commented Dec 1, 2023

Thanks a lot for your contribution! However, the Eclipse Contributer Agreement check is failing. Did you link your GitHub account with your Eclipse account? Are you using the same mails?

I needed to sign again. Now it works :)

@oalagtash
Copy link
Contributor Author

The build is failing on aas registry - probably because I increased the java version to from 11 to 17.
The image being used is java-17. I would suggest we either downgrade the docker image to java-11 or try fixing this error.
I also noticed that submodel registry is already on java-17.

@FrankSchnicke
Copy link
Contributor

Since Spring 3 is using Java 17 would a downgrade really help?

@oalagtash
Copy link
Contributor Author

Since Spring 3 is using Java 17 would a downgrade really help?

It makes probably more sense to fix the errors instead of downgrading.

Copy link
Contributor

@mdanish98 mdanish98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@FrankSchnicke FrankSchnicke merged commit eca2af2 into eclipse-basyx:main Dec 12, 2023
2 checks passed
@oalagtash oalagtash deleted the op-fork/docker-maven-contribution branch December 12, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants