Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate docker image publishing workflow #154

Closed
wants to merge 5 commits into from

Conversation

mhrimaz
Copy link
Contributor

@mhrimaz mhrimaz commented Dec 7, 2023

This workflow automatically publish docker images for repositories

  • latest tag used, for specific version publication, I can further enhance the workflow.
  • No test will be runned, since it is assumed that a push on main branch pass previous builds.
  • Multi-platform build adds support for arm images as requested in AAS Environment Docker image not compatible with ARM #18 . I briefly tested images on EC2 arm instance. @BlackRose01 or maybe another person can validate more throughly. Images available in this repository with different tags, I will remove the repository when the pull request accepted
    image
    image

@FrankSchnicke
Since no repository created for AASX file server i choose this name eclipsebasyx/aasx-file-server-repository, but you can change.

Before merging make sure to add docker hub credentials as secret in the repository setting.

@BlackRose01
Copy link

Hi,

thank you @mhrimaz. I just tested your images on an Nvidia Jetson and it worked. All images started without any problems or warnings.

KR,
BlackRose01

@FrankSchnicke
Copy link
Contributor

Hi @mhrimaz,

thank you very much for this contribution! We're right now in the process of harmonizing our docker build process since we're using maven for building in the images. This enables us to run various integration tests against the containers to ensure no errors in the dockerfile. Thus, I won't be able to merge your PR right now due to the other ongoing activities.

I will come back to this PR when the other activities are concluded.

@aaronzi
Copy link
Member

aaronzi commented Dec 9, 2024

PR #562 implements this by also including the registries. It uses 2.0.0-SNAPSHOT as the tag instead of latest. Since this workflow is now implemented and working, I will close this PR.

@aaronzi aaronzi closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants