Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include missing commons-io dependency for AAS Thumbnails implementation #161

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Include missing commons-io dependency for AAS Thumbnails implementation #161

merged 1 commit into from
Dec 14, 2023

Conversation

oalagtash
Copy link
Contributor

The built jar of basyx.aasrepository.component does not include this dependency. (It was only included for tests)

I stumbled on this when I tested the new thumbnails endpoint running within a docker image.
image

Before:
image

Now:
image

@FrankSchnicke FrankSchnicke merged commit 6682e75 into eclipse-basyx:main Dec 14, 2023
2 checks passed
@FrankSchnicke
Copy link
Contributor

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oalagtash @FrankSchnicke