Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CORS allowed methods to spring configuration #164

Merged
merged 4 commits into from
Jan 3, 2024
Merged

Added CORS allowed methods to spring configuration #164

merged 4 commits into from
Jan 3, 2024

Conversation

aaronzi
Copy link
Member

@aaronzi aaronzi commented Dec 17, 2023

Currently, only the allowed origins can be configured. However, allowed methods are also needed to send requests to the BaSyx SDK from the browser. By default GET, HEAD and POST are allowed which is not enough when looking at the API specs. The BaSyx AAS Web UI needs for example PATCH to write values to a Property.

@FrankSchnicke
Copy link
Contributor

Thanks a lot for providing this extension! However, I moved the current content of the Readme.md to a separate file (https://github.com/eclipse-basyx/basyx-java-server-sdk/blob/main/docs/Components.md), thus creating a merge conflict.

Would it be possible to adapt your PR to add the new documentation to Components.md instead?

@aaronzi
Copy link
Member Author

aaronzi commented Jan 2, 2024

@FrankSchnicke I adapted the PR according to the changes to the documentation.

@FrankSchnicke
Copy link
Contributor

Thanks a lot!

@FrankSchnicke FrankSchnicke merged commit 39f0f16 into eclipse-basyx:main Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants