Implement Remaining MQTTSubmodelRepo Methods #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateusmolina-iese
suggested changes
Nov 29, 2024
| @@ -9,5 +9,8 @@ This feature provides hierarchical MQTT eventing for a multitude of events: | |||
| | SubmodelElement Created | sm-repository/$repoId/submodels/$submodelIdBase64URLEncoded/submodelElements/$idShortPath/created | Created SubmodelElement JSON | | |||
| | SubmodelElement Updated | sm-repository/$repoId/submodels/$submodelIdBase64URLEncoded/submodelElements/$idShortPath/updated | Updated SubmodelElement JSON | | |||
| | SubmodelElement Deleted | sm-repository/$repoId/submodels/$submodelIdBase64URLEncoded/submodelElements/$idShortPath/deleted | Deleted SubmodelElement JSON | | |||
| | SubmodelElements Patched | sm-repository/$repoId/submodels/$submodelIdBase64URLEncoded/submodelElements/patched | Patched SubmodelElements JSON | | |||
| | FileValue Updated | sm-repository/$repoId/submodels/$submodelIdBase64URLEncoded/submodelElements/$idShortPath/fileValue/$fileName/updated | Updated SubmodelElement JSON | | |||
There was a problem hiding this comment.
Can you please change the topic to match the spec [1, 2] (.../$idShortPath/attachment/updated and /deleted)? Also, no need for the $fileName in the topic itself.
[1] https://app.swaggerhub.com/apis/Plattform_i40/SubmodelServiceSpecification/V3.0.1_SSP-001#/Submodel%20API/PutFileByPath
[2] https://app.swaggerhub.com/apis/Plattform_i40/SubmodelServiceSpecification/V3.0.1_SSP-001#/Submodel%20API/DeleteFileByPath
…//github.com/ShehriyarShariq-Fraunhofer/basyx-java-server-sdk into implement-remaining-mqttsubmodelrepo-methods
mateusmolina-iese
approved these changes
Dec 3, 2024
mateusmolina-iese
suggested changes
Dec 3, 2024
| @Override | ||
| public void patchSubmodelElements(String submodelId, List<SubmodelElement> submodelElementList) { | ||
| decorated.patchSubmodelElements(submodelId, submodelElementList); | ||
| List<SubmodelElement> patchedSubmodelElements = decorated.getSubmodelElements(submodelId, PaginationInfo.NO_LIMIT).getResult(); |
There was a problem hiding this comment.
Is there any reason to use the NO_LIMIT request to get the patched submodel elements again? They are already being passed as parameter.
…//github.com/ShehriyarShariq-Fraunhofer/basyx-java-server-sdk into implement-remaining-mqttsubmodelrepo-methods
aaronzi
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented eventing logic + tests for:
Closes #428