Implements InMemory AASX file server #84
Conversation
- Adds core - Adds backend-inmemory - Adds component Signed-off-by: Chaithra Kandur Bhagavanthaiah <[email protected]>
Signed-off-by: Chaithra Kandur Bhagavanthaiah <[email protected]>
Signed-off-by: Chaithra Kandur Bhagavanthaiah <[email protected]>
Signed-off-by: Chaithra Kandur Bhagavanthaiah <[email protected]>
Signed-off-by: Chaithra Kandur Bhagavanthaiah <[email protected]>
| /** | ||
| * Retrieves all AASXPackageIds from the repository | ||
| * | ||
| * @return a list of available AASX packages at the server |
There was a problem hiding this comment.
Please improve this, as it is not returning the AASX packages.
| public interface AasxFileServer { | ||
|
|
||
| /** | ||
| * Retrieves all AASXPackageIds from the repository |
| * @param packageId | ||
| * @throws ElementDoesNotExistException | ||
| */ | ||
| public void deleteAASXPackageById(String packageId) throws ElementDoesNotExistException; |
There was a problem hiding this comment.
Please rename it to deleteAASXByPackageId
| public PackageDescription createAASXPackage(List<String> aasIds, InputStream file, String fileName) throws CollidingIdentifierException; | ||
|
|
||
| /** | ||
| * Deletes a AASXPackage |
| public void updateAASXByPackageId(String packageId, List<String> aasIds, InputStream file, String filename) throws ElementDoesNotExistException; | ||
|
|
||
| /** | ||
| * Creates a new AASXPackage |
| packageMap.remove(packageId); | ||
| } | ||
|
|
||
| public Integer increment(Integer n) { |
There was a problem hiding this comment.
No usage of this method, please remove this.
| return n++; | ||
| } | ||
|
|
||
| private PackageDescription createPackageDescription(List<String> aasIds, String newpackageId) { |
| return packagesBody; | ||
| } | ||
|
|
||
| private void createPackage(List<String> aasIds, InputStream file, String fileName, String newpackageId, PackageDescription packageDescription) { |
| public Collection<PackageDescription> getAllAASXPackageIds() { | ||
|
|
||
| return packageMap.values().stream() | ||
| .map(aasxPackage -> aasxPackage.getPackageDescription()) |
There was a problem hiding this comment.
Please use Package::getPackageDescription
| import org.springframework.stereotype.Component; | ||
|
|
||
| /** | ||
| * AasxFileServer factory returning an in-memory backend AasxFileServer |
There was a problem hiding this comment.
Please use @link to mention the class
…m data Signed-off-by: Chaithra Kandur Bhagavanthaiah <[email protected]>
| PackageDescription expectedFirstPackage = iterator.next(); | ||
| PackageDescription expectedSecondPackage = iterator.next(); | ||
|
|
||
| assertTrue(packageDescriptions.containsAll(Arrays.asList(expectedFirstPackage, expectedSecondPackage))); |
There was a problem hiding this comment.
This is wrong, actual is same as the expected.
There was a problem hiding this comment.
Inconsistent naming of class.
Please either use AASX* or Aasx* everywhere.
There was a problem hiding this comment.
Inconsistent naming of class.
Please either use AASX* or Aasx* everywhere.
There was a problem hiding this comment.
Please put this inside a new package named "model".
Also, put PackDesc and PackBody classes in the same package.
| package org.eclipse.digitaltwin.basyx.aasxfileserver; | ||
|
|
||
| /** | ||
| * Specifies the Package for AasxFileServer |
There was a problem hiding this comment.
Please use @_link to reference classes
| import org.eclipse.digitaltwin.basyx.core.exceptions.ElementDoesNotExistException; | ||
|
|
||
| /** | ||
| * Specifies the overall AasxFileServer API |
There was a problem hiding this comment.
Please use @_link to reference classes
| * @param filename | ||
| * @throws CollidingIdentifierException | ||
| */ | ||
| public PackageDescription createAASXPackage(List<String> aasIds, InputStream file, String fileName) throws CollidingIdentifierException; |
There was a problem hiding this comment.
As identifier is generated automatically at runtime, there is no chance of collision.
Please remove this throws declaration.
| } | ||
|
|
||
| @Override | ||
| public PackageDescription createAASXPackage(List<String> aasIds, InputStream file, String fileName) |
There was a problem hiding this comment.
As identifier is generated automatically at runtime, there is no chance of collision.
Please remove this throws declaration.
| import org.eclipse.digitaltwin.basyx.core.exceptions.ElementDoesNotExistException; | ||
|
|
||
| /** | ||
| * In-memory implementation of the AASXFileServer |
...rc/main/java/org/eclipse/digitaltwin/basyx/aasxfileserver/InMemoryAASXFileServerFactory.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Please check and add all other missing properties.
Refer other repositories component.
There was a problem hiding this comment.
The createAASXPackage test is missing, please add it.
There was a problem hiding this comment.
added the test case
…r-sdk into feature/aasx-fs-inmem
Signed-off-by: Chaithra Kandur Bhagavanthaiah <[email protected]>
…/basyx-java-server-sdk into feature/aasx-fs-inmem
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
| * | ||
| * @return a list of available AASX Package Descriptions at the server | ||
| */ | ||
| public Collection<PackageDescription> getAllAASXPackageIds(); |
There was a problem hiding this comment.
Missing param aasId (see SPOTAAS Part2, 5.5.2 Operation GetAllAASXPackageIds, p. 45)
e.g. overload method
There was a problem hiding this comment.
(according to our naming guide lines the param should be named shellId)
| protected abstract AASXFileServer getAASXFileServer(); | ||
|
|
||
| @Test | ||
| public void getAllAASXPackageIds() { |
There was a problem hiding this comment.
Please add a test case for getAASXFileServer(String shellId)
| public AASXFileServerFeaturePrinter(List<AASXFileServerFeature> features) { | ||
| logger.info("-------------------- AASX File Server Features: --------------------"); | ||
| for (AASXFileServerFeature feature : features) { | ||
| logger.info("BaSyxFeature " + feature.getName() + " is enabled: " + feature.isEnabled()); |
There was a problem hiding this comment.
logger Strings can be formatted like
logger.info("BaSyxFeature '{}' is enabled: {}", feature.getName(), feature.isEnabled())
Signed-off-by: Mohammad Ghazanfar Ali Danish <[email protected]>
Signed-off-by: Chaithra Kandur Bhagavanthaiah [email protected]