Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix submodelElements loss after calling $metamodel endpoint #95

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Fix submodelElements loss after calling $metamodel endpoint #95

merged 2 commits into from
Oct 4, 2023

Conversation

mhrimaz
Copy link
Contributor

@mhrimaz mhrimaz commented Oct 2, 2023

See issue #85

FrankSchnicke
FrankSchnicke requested changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@FrankSchnicke FrankSchnicke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this PR! There is a minor remark from my side, can you take a look at it and update the PR?

...c/main/java/org/eclipse/digitaltwin/basyx/submodelrepository/InMemorySubmodelRepository.java Outdated Show resolved Hide resolved
...c/main/java/org/eclipse/digitaltwin/basyx/submodelrepository/InMemorySubmodelRepository.java Outdated Show resolved Hide resolved
@FrankSchnicke FrankSchnicke merged commit c4242c8 into eclipse-basyx:main Oct 4, 2023
1 check passed
@FrankSchnicke
Copy link
Contributor

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankSchnicke FrankSchnicke FrankSchnicke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhrimaz @FrankSchnicke