fix(gen): clarify some ValueDataType hints

eclipse-basyx · Jan 16, 2025 · cb49285 · cb49285
1 parent 75de266
commit cb49285
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/pdf2aas/generator/aas.py b/src/pdf2aas/generator/aas.py
@@ -17,11 +17,12 @@
 def cast_property(  # noqa: C901, PLR0911
     value: Any,
     definition: PropertyDefinition | None = None,
-) -> model.ValueDataType:
+) -> model.ValueDataType | None:
     """Cast a value to an XSD DataType from the AAS module.
 
     Uses the definition.type if given and type() casts to find the type.
     Currently only Boolean, String, Integer and Float target types are supported.
+    Returns None, if value is None.
     """
     if value is None:
         return None

diff --git a/src/pdf2aas/generator/aas_technical_data_submodel.py b/src/pdf2aas/generator/aas_technical_data_submodel.py
@@ -174,7 +174,7 @@ def _create_submodel_template(self) -> model.Submodel:
             model.Property(
                 id_short="ValidDate",
                 value_type=model.datatypes.Date,
-                value=datetime.now(tz=timezone.utc).date(),
+                value=datetime.now(tz=timezone.utc).date(), # type: ignore [arg-type]
                 category="PARAMETER",
                 semantic_id=self._create_semantic_id(
                     "https://admin-shell.io/ZVEI/TechnicalData/ValidDate/1/1",
@@ -415,7 +415,7 @@ def _create_aas_property_smc(
     def _create_aas_property_recursive(
         self,
         property_: Property,
-        value: model.ValueDataType,
+        value: model.ValueDataType | None,
         id_short: str,
         display_name: model.MultiLanguageNameType | None,
         description: model.MultiLanguageTextType | None,