model.base: fix ModelReference.resolve() error messages for elements contained in SubmodelElementLists
#128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s contained in `SubmodelElementLists` Some error messages raised in `ModelReference.resolve()` make use of the `resolved_keys` local list variable, which keeps track of all Identifiers, id_shorts and `SubmodelElementList` indices that have been resolved successfully. Instead of `SubmodelElementList` indices, the children's id_shorts were added to this list previously, which is inconsistent, and soon would cease to work anyway, since AASd-120 prohibits specifying id_shorts for children of `SubmodelElementList`. This commit fixes this such that indices are added and adjusts the tests accordingly.
Merged
|
Lgtm |
s-heppner
deleted the
fix/ModelReference_resolved_path_for_SubmodelElementLists
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some error messages raised in
ModelReference.resolve()make use of theresolved_keyslocal list variable, which keeps track of all Identifiers, id_shorts andSubmodelElementListindices that have been resolved successfully.Instead of
SubmodelElementListindices, the children's id_shorts were added to this list previously, which is inconsistent, and soon would cease to work anyway, since AASd-120 prohibits specifying id_shorts for children ofSubmodelElementList.This commit fixes this such that indices are added and adjusts the tests accordingly.