Remove DataSpecificationPhysicalUnit #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, however, can you fix the conflicts? |
|
@s-heppner I have no right to do that: "Only those with write access to this repository can merge pull requests." The conflict problems occur with .aasx files because the are zipped. You can just accept my files. |
|
You could just rebase on EDIT: Ah no, the AASX files will have to be merged manually and can't be checked out via |
…_phys_unit # Conflicts: # test/compliance_tool/files/test_demo_full_example_json.aasx # test/compliance_tool/files/test_demo_full_example_xml.aasx # test/compliance_tool/files/test_demo_full_example_xml_wrong_attribute.aasx
|
@jkhsjdhjs thanks for the advice. I have done the fixes manually in the test files. I had to remove ".www" subdomain in AASX namespace once again |
Frosty2500
pushed a commit
to rwth-iat/basyx-python-sdk
that referenced
this pull request
Aug 22, 2024
As the DataSpecificationPhysicalUnit is not part of V3.0 it was removed from the SDK. Fixes eclipse-basyx#136
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the DataSpecificationPhysicalUnit is not part of V3.0 it was removed from the SDK.
Fixes #136