adapter.json: Update Schema to comply with v3.0 #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please note, that according to [eclipse-basyx#72], we decided not to include the `File` pattern, since the specification is wrong at this. [eclipse-basyx#72](eclipse-basyx#72)
|
Can someone please have a look at this? I've been at it for hours and I can't find the remaining problem with the schema. It appears to be something with the |
These went unnoticed previously since the JSON schema doesn't prohibit additional attributes. Now that the `modelType` is defined as a constant string per definition, a `Property` object only matches against the corresponding definition, allowing more strict validation, that catches errors such as these null values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the JSON Schema with the missing changes of the specified schema.
However, as noted in #72, we did not include the regex patterns for the
File.