adapter.aasx: allow deleting files from SupplementaryFileContainer
#278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-heppner
requested changes
Jun 13, 2024
`AbstractSupplementaryFileContainer` and `DictSupplementaryFileContainer` are extended by a `delete_file()` method, that allows deleting files from them. Since different files may have the same content, references to the files contents in `DictSupplementaryFileContainer._store` are tracked via `_store_refcount`. A files contents are only deleted from `_store`, if all filenames referring to these these contents are deleted, i.e. if the refcount reaches 0.
jkhsjdhjs
force-pushed
the
aasx/file_container_deletion
branch
from
f3c25b9 to
3a11141
Compare
s-heppner
approved these changes
Jun 13, 2024
|
Looks good to me, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractSupplementaryFileContainerandDictSupplementaryFileContainerare extended by adelete_file()method, that allows deleting files from them. Since different files may have the same content, references to the files contents inDictSupplementaryFileContainer._storeare tracked via_store_refcount. A files contents are only deleted from_store, if all filenames referring to these these contents are deleted, i.e. if the refcount reaches 0.