-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
basyx: add server with git history. #297
Conversation
The nginx config has been moved in 38303ef.
This makes the server read AASX files by default, as it seems to be the most common usecase. Furthermore, the user can now configure the container via environment variables. These options are also documented in the README.
This makes the server also read JSON and XML files
This reverts commit 31f9ea3.
- This commit adds support for loading AASX, JSON or XML files. So the user can have a mix of these files in the storage folder and the application will load them all. - Changed types of storage to LOCAL_FILE_BACKEND and LOCAL_FILE_READ_ONLY - Adapted and refactored README.md and added more examples for running
Lower the suffixes to also match the filenames with uppercase suffixes
Add server to basyx-python-sdk.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Can you create an issue to refactor the Dockerfile
away from tiangolo/uwsgi-nginx:python3.11
and to a more generic Python Alpine or somehting similar (https://hub.docker.com/_/python)?
After researching a bit more I want to ask, are you @s-heppner sure it makes sense to keep all the pyproject.toml files in the same directory directly in basyx? Would it not make more sense to aim for this kind of structure for our project: basyx-python-sdk This seems more so like the standard practice for monorepos. |
This is the structure that I had in my mind, so yes can you adapt this, if it wasn't the case. Sorry that I didn't notice before. |
Can you also add the link to the specification of Part 2 to the |
I just realized, please make sure to also update the branch to |
Moved this to a different branch |
Add the content and git history of https://github.com/rwth-iat/basyx-python-sdk-http-server-docker under the folder basyx.