SDK: Bump required Python version to >= 3.9, Add version CI check #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-heppner
force-pushed
the
Fix/CI/PythonVersions
branch
4 times, most recently
from
ab21d78 to
b91718f
Compare
This bumps the `requires-python` fiels in the `pyproject.toml` of the SDK from `">=3.8"` to `">=3.9"`, due to the fact that Python v3.8 reached EoL on 2024-10-07. Furthermore, to avoid future backward compatibility issues in native Python, as well as to ensure we're always supporting the currently supported Python versions, we add a CI check `check-python-versions` that uses two new scripts in `./etc/scripts` to check: a) our currently supported Python versions to an EoL database b) that our currently supported Python versions defined in the CI match the ones in the `pyproject.toml`. This should ensure that issues like eclipse-basyx#330 are avoided in the future. (Note that we still need to fix eclipse-basyx#330 though).
s-heppner
force-pushed
the
Fix/CI/PythonVersions
branch
from
b91718f to
1e93fa5
Compare
Currently, we're using `datetime.UTC`, a constant defined in the built-in `datetime` module. However, this constant was only introduced in Python version 3.11, as you can see in the documentation: - Does not exist in [datetime Python 3.10] - Exists in [datetime python 3.11] We did not catch this, as we most likely programmed the module with Python >= 3.11 and our CI also ran `mypy` with Python 3.12. [datetime Python 3.10]: https://docs.python.org/3.10/library/datetime.html#constants [datetime python 3.11]: https://docs.python.org/3.11/library/datetime.html#datetime.UTC Fixes eclipse-basyx#330
s-heppner
force-pushed
the
Fix/CI/PythonVersions
branch
from
767fc57 to
e17d7c4
Compare
zrgt
suggested changes
Nov 15, 2024
|
@s-heppner please check rwth-iat#59 |
zrgt
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps the
requires-pythonfield in thepyproject.tomlof the SDK from">=3.8"to">=3.9", due to the fact that Python v3.8 reached EoL on 2024-10-07.Furthermore, to avoid future backward compatibility issues with the supported Python versions, as well as to ensure we're always supporting the currently supported Python versions, we add a CI check
check-python-versionsthat uses two new scripts in./etc/scriptsto check:a) our currently supported Python versions to an EoL database
b) that our currently supported Python versions defined in the CI match the ones in the
pyproject.toml.This should ensure that issues like #330 are avoided in the future.
adapter.http: Fix reference to constant from the future
Currently, we're using
datetime.UTC, a constant defined in the built-indatetimemodule.However, this constant was only introduced in Python version 3.11, as you can see in the documentation:
We did not catch this, as we most likely programmed the module with Python >= 3.11 and our CI also ran
mypywith Python 3.12.Depends on rwth-iat#59
Fixes #330