Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compliance-tool: Fix compliance tool imports and unitests #356

Merged
merged 8 commits into from
Jan 15, 2025

Conversation

Frosty2500
Copy link
Contributor

@Frosty2500 Frosty2500 commented Dec 14, 2024

Currently there are quite some wrong imports in the compliance-tool directory. Even when those are fixed many Unitests still fail.
Here these imports are fixed.
Fixes #354

@Frosty2500
Copy link
Contributor Author

Frosty2500 commented Dec 28, 2024

The reason why the python 3.8 compliance-tool-test does not work seems to be because it seems to be generating older aas examples with spelling mistakes in the check_object_store method. The 3.10 and 3.12 versions generate the correct example data. I am just not sure why this is the case.

@Frosty2500 Frosty2500 force-pushed the fix_compliance_tool branch 2 times, most recently from 30c33be to 8881751 Compare December 28, 2024 22:58
@Frosty2500
Copy link
Contributor Author

I just remembered that we do not support Python 3.8 anymore so that test not working does not matter. I will adapt the ci accordingly.

Copy link
Contributor

@s-heppner s-heppner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that small issue, this LGTM!

@s-heppner s-heppner merged commit 1ca495f into eclipse-basyx:develop Jan 15, 2025
14 checks passed
@s-heppner s-heppner deleted the fix_compliance_tool branch January 15, 2025 08:39
@s-heppner s-heppner added this to the Release v1.1.1 milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants