Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show column in TimegraphOutputComponent if back-end provides them #1152

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Show column in TimegraphOutputComponent if back-end provides them #1152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react-components/src/components/timegraph-output-component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,6 +540,7 @@ export class TimegraphOutputComponent extends AbstractTreeOutputComponent<Timegr
className="table-tree timegraph-tree"
emptyNodes={this.state.emptyNodes}
hideEmptyNodes={this.shouldHideEmptyNodes}
headers={this.state.columns}
/>
</div>
<div ref={this.markerTreeRef} className="scrollable" style={{ height: this.getMarkersLayerHeight() }}>
Expand Down
6 changes: 4 additions & 2 deletions packages/react-components/style/output-components-style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,17 +306,19 @@ canvas {
}

.timegraph-tree {
border: 0px;
border-collapse: collapse;
}

.timegraph-tree tr {
/* TODO: Fix row alignment, this number is arbitrary, it works [on my machine], but it should match line height in timeline-chart */
line-height: 18px;
border:none;
}

.timegraph-tree td {
padding: 1px;
border: 0px;
border-left: 1px solid var(--trace-viewer-tree-inactiveIndentGuidesStroke);
border-bottom:none;
}

#input-filter-container {
Expand Down
Loading