Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeline chart selected row visibility issue #116

Open
hriday-panchasara opened this issue Mar 16, 2023 · 4 comments
Open

Timeline chart selected row visibility issue #116

hriday-panchasara opened this issue Mar 16, 2023 · 4 comments
Assignees
@hriday-panchasara
Labels
bug Something isn't working vscode-extension Something in the vscode-extension repository

Comments

@hriday-panchasara
Copy link
Contributor

hriday-panchasara commented Mar 16, 2023 •
edited
Loading

The selected row highlighting blocks the states in the TimeGraph View:

Screen.Recording.2023-03-16.at.5.09.13.PM.webm

Here's how the same view looks like in theia-trace-extension:
Screen Shot 2023-03-16 at 5 10 44 PM

For reference, here's the PR in theia-trace-extension that introduced highlighting of selected rows:
eclipse-cdt-cloud/theia-trace-extension#788
@hriday-panchasara hriday-panchasara added bug Something isn't working vscode-extension Something in the vscode-extension repository labels Mar 21, 2023
@hriday-panchasara
Copy link
Contributor Author

Picked by Traviz

@williamsyang-work williamsyang-work mentioned this issue May 15, 2023
Merged
@williamsyang-work
Copy link
Contributor

Submitted a PR in theia-trace-extension that fixes this issue: eclipse-cdt-cloud/theia-trace-extension#975.

@bhufmann
Copy link
Collaborator

Submitted a PR in theia-trace-extension that fixes this issue: eclipse-cdt-cloud/theia-trace-extension#975.

The PR has been merged. Next upgrade in this repo will pick-up the change.

@hriday-panchasara
Copy link
Contributor Author

@williamsyang-work Still noticing the issue. Could you check and introduce an uplift patch if needed?

@hriday-panchasara hriday-panchasara self-assigned this Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hriday-panchasara hriday-panchasara

Labels
bug Something isn't working vscode-extension Something in the vscode-extension repository
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bhufmann @hriday-panchasara @williamsyang-work