Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color String Whitespace hotfix #975

Conversation

williamsyang-work
Copy link
Contributor

@williamsyang-work williamsyang-work commented May 15, 2023

Trims the whitespace off of the input string. This fixes an issue that is occurring in the CodeOSS migration: eclipse-cdt-cloud/vscode-trace-extension#116.

Signed-off-by: Will Yang [email protected]

Trims the whitspace off of the input string.  This fixes an issue that
is occurring in the CodeOSS migration.

Signed-off-by: Will Yang <[email protected]>
Copy link
Contributor

@hoangphamEclipse hoangphamEclipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@bhufmann bhufmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@bhufmann bhufmann merged commit e5c898d into eclipse-cdt-cloud:master May 19, 2023
@williamsyang-work williamsyang-work deleted the color-string-edge-case-hotfix branch August 21, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants