Fix path failure preventing trace from opening #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PatrickTasse @bhufmann please review asap. Opening traces using the 'traces.openTraceFile' command directly does not work on windows without this patch! Thank you :) |
elaskavaia
reviewed
Oct 26, 2023
elaskavaia
reviewed
Oct 26, 2023
dleclairbb
force-pushed
the
fix-trace-paths-windows
branch
from
cb950a6 to
32f2b75
Compare
elaskavaia
approved these changes
Oct 26, 2023
bhufmann
requested changes
Oct 27, 2023
When doing some testing on an internal extension relying, I noticed that we could no longer use the Open With TraceViewer command on Windows due to an invalid path failing (worked on Linux). I was able to trace the cause of this it to some code that uses .path instead of .fsPath, which is intended for use with the filesystem and scrubs out improper path values (which is what caused our error!). I also changed some other path calculations to be less error prone across platforms by using the path API. This fixes a critical issue which prevents users from opening traces in some cases. Signed-off-by: Dylan Leclair <[email protected]>
dleclairbb
force-pushed
the
fix-trace-paths-windows
branch
from
32f2b75 to
84e4944
Compare
|
I must have missed that when I was squashing the other changes in - sorry about that! Thank you :) |
marcdumais-work
approved these changes
Oct 27, 2023
bhufmann
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing some testing on an internal extension, I noticed that we could no longer use the Open With TraceViewer command on Windows due to an invalid path failing (worked on Linux).
I was able to trace the cause of this it to some code that uses .path instead of .fsPath, which is intended for use with the filesystem and scrubs out improper path values (which is what caused our error!) I also fixed this in other areas of the code.
This fixes a critical issue which prevents users from opening traces in some cases.