-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger first release to open-vsx.org #194
Conversation
9309759
to
3e20521
Compare
Note: We will need to change RELEASE to add a bogus release tag, previous to |
6c5ebc0
to
0b579d7
Compare
done in #197 |
ac36b79
to
bbf0d7b
Compare
bbf0d7b
to
a1cff60
Compare
This comment was marked as outdated.
This comment was marked as outdated.
27b5f68
to
21c6e4b
Compare
21c6e4b
to
69e242e
Compare
093f514
to
92c7e44
Compare
92c7e44
to
045f13b
Compare
045f13b
to
3812505
Compare
This comment was marked as outdated.
This comment was marked as outdated.
7028ea5
to
e6ba2ec
Compare
b72d577
to
4440d16
Compare
This comment was marked as outdated.
This comment was marked as outdated.
d0b41ba
to
2f4e1f8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
2f4e1f8
to
7b044c2
Compare
d173eba
to
8b7ac11
Compare
752a68d
to
a1b5697
Compare
- Add new tag and some options related to automatic release notes generation to file RELEASE - Step extension's version - Have test setup not rely on hardcoded extension version in filename, by using a glob Signed-off-by: Marc Dumais <[email protected]>
a1b5697
to
cc17f90
Compare
The following 1 GitHub releases will be created once this pull request got merged. Release v0.2.0 with changes since v0.0.0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks for the quick review! |
This is the first try, so we may need to adjust some things to make it work in the end.
The idea is to update file
RELEASE
, adding a new release tag in there. Then we expect that tentative, automatically-generated release notes, will be added to this PR, for our review. Once we merge the PR, a GitHub release v0.2.0 should be created automatically in the repo, with attached release notes. The tag's creation should then trigger the job that published the extension to open-vsx.org.Note: I picked v0.2.0 to avoid conflicting with the "vscode trace extension", that's already released on the Visual Studio Marketplace (which is currently at v0.1.44). I propose we go with a v1.0.0 version after discussions with other contributors, and after our release/publish infrastructure has been demonstrated to work well.
See below for the automatically generated release notes we are currently obtaining. I played-around with the options quite a bit and something about them is flaky - it could be due to the slightly strange initial run we have, going-back a long while in history, for this first run. In any case, the generation does not need to be perfect -any committer can edit them after the fact, from the GitHub release page.
I think it might be a bit controversial to have both commits and PRs documented in there - I personally like the idea of having one page where we can quickly find both, but I suggest we adjust the options after merging this PR, at the next release - I hope it will work better then.