[CI] Trigger publish job on tag creation, try again to publish #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we previously created the v0.2.0 release using the RELEASE file, the corresponding GitHub release and git tag were created. However the publish job was not triggered. Testing on my fork, I concluded that the workflow needs to trigger on "create" tag, not on "push". A slight side-effect of triggering the ci-cd workflow on "create" events is that it will now run also on branch creation. So it may run a bit more often than before. I think this is preferable for now, vs having complex "if:" conditions on each job in the workflow. This commit fixes this. Signed-off-by: Marc Dumais <[email protected]>
This commit steps the tag in file RELEASE to v0.2.1 to trigger a new release, which this time will hopefully trigger the publish job and successfully publish the extension to open-vsx. Afterwards, I plan to delete the (failed) v0.2.0 release, and copy its generated release notes to the new release Signed-off-by: Marc Dumais <[email protected]>
MatthewKhouzam
approved these changes
Feb 2, 2024
bhufmann
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we previously created the v0.2.0 release using the RELEASE file, the corresponding GitHub release and git tag were created. However the publish job was not triggered. Testing on my fork, I concluded that the workflow needs to trigger on "create" tag, not on "push". One commit in this PR fixes this.
A slight side-effect of triggering the ci-cd workflow on "create" events is that it will now run also on branch creation. So it may run a bit more often than before. I think this is preferable for now, vs having complex "if:" conditions on each job in the workflow.
Also, in a separate commit, we step the tag in file RELEASE to v0.2.1 to trigger a new release, which this time will hopefully trigger the publish job and successfully publish the extension to open-vsx. Afterwards, I plan to delete the (failed) v0.2.0 release, after copying its generated release notes to the new release