Restore the empty activity IDs #1045
Conversation
In eclipse-cdt#974 I removed activities we were not using anymore, but it turns out if LaunchUtils.enableActivity is called on a removed id, strange things happen, such as other activities incorrectly being enabled. This may be a bug in platform, or just undefined behavior. But because extenders do have calls to LaunchUtils.enableActivity in their code, leave the empty activity ids behind. Fixes eclipse-cdt#1044
|
Concretely, this PR makes sure that the refresh button doesn't appear in the UI when it isn't enabled explicitly by the user. |
|
I have figured out why this change matters. Eclipse Platform UI has an optimization where if the number of enabled activity IDs == number of properly defined activity IDs then all activities are considered enabled (link to code). This caused refresh button to be enabled because we enabled the dsfgdb id (link) but had removed the ID from the defined IDs, so we hit this optimization in platform and the refresh button (and a bunch of other things presumably) got enabled. |
Test Results 635 files ±0 635 suites ±0 55m 22s ⏱️ +2s For more details on these failures and errors, see this check. Results for commit 0f6e39c. ± Comparison against base commit 3439e0e. |
|
Known fails from #816 |
In #974 I removed activities we were not using anymore, but it turns out if LaunchUtils.enableActivity is called on a removed id, strange things happen, such as other activities incorrectly being enabled. This may be a bug in platform, or just undefined behavior. But because extenders do have calls to LaunchUtils.enableActivity in their code, leave the empty activity ids behind.
Fixes #1044