Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribute controller.devfile.io/bootstrap-devworkspace: true when Devfile resolution via API fails or is not supported #1016

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

akurinnoy
Copy link
Contributor

@akurinnoy akurinnoy commented Dec 6, 2023

What does this PR do?

This PR adds the attribute controller.devfile.io/bootstrap-devworkspace: true when Devfile resolution via API fails or is not supported.

What issues does this PR fix or reference?

resolves eclipse-che/che#22697

Is it tested? How?

  1. Deploy Eclipse Che and the dashboard image from this PR:
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1016", name: che-dashboard}]}}]"
  1. Add your SSH keys to the Dashboard, and make sure the public one is uploaded to your Git provider.
  2. Copy the git+SSH URL of your git repository, and create a new workspace using this URL.
  3. The workspace should start successfully with the project cloned and the Devfile applied.

Copy link

openshift-ci bot commented Dec 6, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@che-bot
Copy link
Contributor

che-bot commented Dec 6, 2023

Click here to review and test in web IDE: Contribute

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d4ebc4a) 87.91% compared to head (b9bd0a2) 87.94%.
Report is 4 commits behind head on main.

Files Patch % Lines
...paceProgress/CreatingSteps/Apply/Devfile/index.tsx 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1016      +/-   ##
==========================================
+ Coverage   87.91%   87.94%   +0.02%     
==========================================
  Files         382      383       +1     
  Lines       39261    39311      +50     
  Branches     2593     2607      +14     
==========================================
+ Hits        34517    34571      +54     
+ Misses       4719     4715       -4     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 6, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1016

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1016", name: che-dashboard}]}}]"

Copy link

github-actions bot commented Dec 8, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1016

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1016", name: che-dashboard}]}}]"

@akurinnoy akurinnoy marked this pull request as ready for review December 8, 2023 13:17
@ibuziuk ibuziuk requested a review from l0rd December 8, 2023 14:23
Copy link
Contributor

@olexii4 olexii4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Dec 13, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@svor svor merged commit 5f77dd8 into main Dec 20, 2023
15 checks passed
@svor svor deleted the resolve-devfile branch December 20, 2023 14:07
@devstudio-release
Copy link

Build 3.12 :: dashboard_3.x/428: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.12 :: dashboard_3.x/428: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5729 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.12 :: update-digests_3.x/5306: UNSTABLE

No new images detected: nothing to do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants