-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add attribute controller.devfile.io/bootstrap-devworkspace: true when Devfile resolution via API fails or is not supported #1016
Conversation
Skipping CI for Draft Pull Request. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1016 +/- ##
==========================================
+ Coverage 87.91% 87.94% +0.02%
==========================================
Files 382 383 +1
Lines 39261 39311 +50
Branches 2593 2607 +14
==========================================
+ Hits 34517 34571 +54
+ Misses 4719 4715 -4
Partials 25 25 ☔ View full report in Codecov by Sentry. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1016 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1016", name: che-dashboard}]}}]" |
Signed-off-by: Oleksii Kurinnyi <[email protected]>
7cf857d
to
b9bd0a2
Compare
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1016 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1016", name: che-dashboard}]}}]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.12 :: dashboard_3.x/428: Console, Changes, Git Data |
Build 3.12 :: sync-to-downstream_3.x/5729: Console, Changes, Git Data |
Build 3.12 :: push-latest-container-to-quay_3.x/3994: Console, Changes, Git Data |
Build 3.12 :: get-sources-rhpkg-container-build_3.x/5601: dashboard : 3.x :: Build 57737822 : quay.io/devspaces/dashboard-rhel8:3.12-9 |
Build 3.12 :: dashboard_3.x/428: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5729 triggered |
Build 3.12 :: update-digests_3.x/5306: Console, Changes, Git Data |
Build 3.12 :: update-digests_3.x/5306: No new images detected: nothing to do! |
What does this PR do?
This PR adds the attribute
controller.devfile.io/bootstrap-devworkspace: true
when Devfile resolution via API fails or is not supported.What issues does this PR fix or reference?
resolves eclipse-che/che#22697
Is it tested? How?