Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[config] Changing folder structure for SAttributes and Attributebuilder #1749

Merged
merged 1 commit into from
Sep 30, 2024
Merged

[config] Changing folder structure for SAttributes and Attributebuilder #1749

merged 1 commit into from
Sep 30, 2024

Conversation

Peguen
Copy link
Contributor

@Peguen Peguen commented Sep 30, 2024

Description

Changed folder structure to a more understandable structure for SAttributes and Attributebuilder.

KerstinKeller
KerstinKeller approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@KerstinKeller KerstinKeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole structure feels a little bit bloated (src/logging/config/builder/...), but I don't really have a better suggestion.

@Peguen Peguen merged commit c2943a7 into master Sep 30, 2024
17 of 20 checks passed
@Peguen Peguen deleted the hotfix/sattr_folder_structure branch September 30, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KerstinKeller KerstinKeller KerstinKeller approved these changes

@rex-schilasky rex-schilasky Awaiting requested review from rex-schilasky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Peguen @KerstinKeller