Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] fix bug that processes will not be "unregistered" correctly. #1764

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

KerstinKeller
Copy link
Contributor

Description

Correctly keeps processes in CExpiringMap of unregistration provider.
Now their id is the process_id instead of "", which lead to process entries overwriting themselves in tthe map kept by the unregistration provider.

Related issues

Fixes #1763

@KerstinKeller KerstinKeller added bug Something isn't working cherry-pick-to-NONE Don't cherry-pick these changes labels Oct 8, 2024
Copy link
Contributor

@rex-schilasky rex-schilasky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KerstinKeller KerstinKeller merged commit cd7f327 into master Oct 8, 2024
23 of 24 checks passed
@KerstinKeller KerstinKeller deleted the hotfix/process-unregistration branch October 9, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cherry-pick-to-NONE Don't cherry-pick these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants