service client connection state handling #1780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…connected (not only registered)
rex-schilasky
added
the
cherry-pick-to-support/v5.13
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| std::lock_guard<std::mutex> const lock(m_client_map_sync); | ||
| auto client = m_client_map.find(service.key); | ||
| if (client != m_client_map.end()) | ||
| auto& client_data = client.second; |
There was a problem hiding this comment.
warning: 'auto &client_data' can be declared as 'const auto &client_data' [readability-qualified-auto]
Suggested change
| auto& client_data = client.second; | |
| const auto& client_data = client.second; |
| // check connections | ||
| std::lock_guard<std::mutex> const lock(m_connected_services_map_sync); | ||
| // lock client map | ||
| std::lock_guard<std::mutex> lock(m_client_map_sync); |
There was a problem hiding this comment.
warning: variable 'lock' of type 'std::lock_guardstd::mutex' can be declared 'const' [misc-const-correctness]
Suggested change
| std::lock_guard<std::mutex> lock(m_client_map_sync); | |
| std::lock_guard<std::mutex> const lock(m_client_map_sync); |
| { | ||
| // Lock mutex for iterating over client session map | ||
| std::lock_guard<std::mutex> const client_map_lock(m_client_map_sync); | ||
| auto& client_data = client.second; |
There was a problem hiding this comment.
warning: 'auto &client_data' can be declared as 'const auto &client_data' [readability-qualified-auto]
Suggested change
| auto& client_data = client.second; | |
| const auto& client_data = client.second; |
| std::lock_guard<std::mutex> const lock(m_client_map_sync); | ||
| auto client = m_client_map.find(iter.key); | ||
| if (client == m_client_map.end()) | ||
| auto& client_key = it->first; |
There was a problem hiding this comment.
warning: 'auto &client_key' can be declared as 'const auto &client_key' [readability-qualified-auto]
Suggested change
| auto& client_key = it->first; | |
| const auto& client_key = it->first; |
FlorianReimold
approved these changes
Nov 6, 2024
rex-schilasky
deleted the
hotfix/service-client-connection-state-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Service client connection state (IsConnected) now handled correctly. Connection state is true if a matching server (at least one) is connected on lower client/service API level. We might change this API even more to return the states of all matching server.
Related issues
#1779
Cherry-pick to