Skip to content

Commit

Permalink
Fix compilation errors caused by changes in org.eclipse.debug.core 3.12
Browse files Browse the repository at this point in the history
Unfortunately for addition of agent we implement two interfaces marked
as "noimplement" - org.eclipse.debug.core.ILaunchConfiguration and
org.eclipse.debug.core.ILaunchConfigurationWorkingCopy , and they got
new methods - see bug 41353.

Fortunately according to our investigations with Marc R. Hoffmann and
because current version works in Photon, seems that we can safely use
throw statement for their implementation.

Bug: 535040
  • Loading branch information
Godin committed May 24, 2018
1 parent 5f0e596 commit 80e6e55
Show file tree
Hide file tree
Showing 4 changed files with 84 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
import java.util.Collections;
import java.util.List;
import java.util.Map;
Expand Down Expand Up @@ -486,6 +487,10 @@ public ILaunchConfigurationWorkingCopy copy(String name)
public void delete() throws CoreException {
}

public void delete(int flag) throws CoreException {
throw new UnsupportedOperationException();
}

public boolean exists() {
return false;
}
Expand Down Expand Up @@ -613,6 +618,33 @@ public boolean isReadOnly() {
return false;
}

public ILaunchConfiguration getPrototype() throws CoreException {
throw new UnsupportedOperationException();
}

public boolean isAttributeModified(String attribute) throws CoreException {
throw new UnsupportedOperationException();
}

public boolean isPrototype() {
throw new UnsupportedOperationException();
}

public Collection<ILaunchConfiguration> getPrototypeChildren() throws CoreException {
throw new UnsupportedOperationException();
}

public int getKind() throws CoreException {
throw new UnsupportedOperationException();
}

public Set<String> getPrototypeVisibleAttributes() throws CoreException {
throw new UnsupportedOperationException();
}

public void setPrototypeAttributeVisibility(String attribute, boolean visible) throws CoreException {
throw new UnsupportedOperationException();
}
}

private static class RecordingListener implements ISessionListener {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
******************************************************************************/
package org.eclipse.eclemma.internal.core.launching;

import java.util.Collection;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
Expand Down Expand Up @@ -104,6 +105,10 @@ public void delete() throws CoreException {
delegate.delete();
}

public void delete(int flag) throws CoreException {
throw new UnsupportedOperationException();
}

public boolean exists() {
return delegate.exists();
}
Expand Down Expand Up @@ -210,4 +215,32 @@ public boolean isReadOnly() {
return delegate.isReadOnly();
}

public ILaunchConfiguration getPrototype() throws CoreException {
throw new UnsupportedOperationException();
}

public boolean isAttributeModified(String attribute) throws CoreException {
throw new UnsupportedOperationException();
}

public boolean isPrototype() {
throw new UnsupportedOperationException();
}

public Collection<ILaunchConfiguration> getPrototypeChildren() throws CoreException {
throw new UnsupportedOperationException();
}

public int getKind() throws CoreException {
throw new UnsupportedOperationException();
}

public Set<String> getPrototypeVisibleAttributes() throws CoreException {
throw new UnsupportedOperationException();
}

public void setPrototypeAttributeVisibility(String attribute, boolean visible) throws CoreException {
throw new UnsupportedOperationException();
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@ public ILaunchConfiguration doSave() throws CoreException {
return delegate.doSave();
}

public ILaunchConfiguration doSave(int flag) throws CoreException {
throw new UnsupportedOperationException();
}

public void setAttribute(String attributeName, int value) {
delegate.setAttribute(attributeName, value);
}
Expand All @@ -86,6 +90,10 @@ public void setAttribute(String attributeName, boolean value) {
delegate.setAttribute(attributeName, value);
}

public void setAttribute(String attributeName, Object value) {
throw new UnsupportedOperationException();
}

public void rename(String name) {
delegate.rename(name);
}
Expand Down Expand Up @@ -127,4 +135,12 @@ public ILaunchConfigurationWorkingCopy getParent() {
return delegate.getParent();
}

public void copyAttributes(ILaunchConfiguration prototype) throws CoreException {
throw new UnsupportedOperationException();
}

public void setPrototype(ILaunchConfiguration prototype, boolean copy) throws CoreException {
throw new UnsupportedOperationException();
}

}
6 changes: 3 additions & 3 deletions org.eclipse.eclemma.target/eclemma-e4.8.target
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
<target name="eclemma-e4.8" sequenceNumber="1">
<locations>
<location includeAllPlatforms="false" includeMode="planner" includeSource="true" type="InstallableUnit">
<unit id="org.eclipse.jdt.feature.group" version="3.14.0.v20171206-2000"/>
<unit id="org.eclipse.rcp.feature.group" version="4.8.0.v20171206-2000"/>
<unit id="org.eclipse.platform.feature.group" version="4.8.0.v20171206-2000"/>
<unit id="org.eclipse.jdt.feature.group" version="3.14.0.v20180509-2000"/>
<unit id="org.eclipse.rcp.feature.group" version="4.8.0.v20180509-2000"/>
<unit id="org.eclipse.platform.feature.group" version="4.8.0.v20180509-2000"/>
<repository location="http://download.eclipse.org/releases/photon/"/>
</location>
<location includeAllPlatforms="false" includeMode="planner" includeSource="true" type="InstallableUnit">
Expand Down

0 comments on commit 80e6e55

Please sign in to comment.