Indented tree layout algorithm #1099
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an indented tree layout algorithm for filesystem-like representations
Moved IntentedTree to correct the level in the hierarchy
Updated Spacings to only have default values where appropriate; improved documentation of spacing options, including graphics.
Eddykasp
reviewed
Dec 18, 2024
There was a problem hiding this comment.
this image doesn't show which node each property needs to be set on
also the text is cut off on the right
There was a problem hiding this comment.
In which representation/context did you see the text cut off?
The file itself is correctly cropped, perhaps it is too wide for some contexts?
There was a problem hiding this comment.
The final "n" of indentation in pink is missing
plugins/org.eclipse.elk.alg.indentedtree/src-gen/org/eclipse/elk/alg/indentedtree/.gitignore
Outdated
Show resolved
Hide resolved
...se.elk.alg.indentedtree/src/org/eclipse/elk/alg/indentedtree/IndentedtreeLayoutProvider.java
Outdated
Show resolved
Hide resolved
...se.elk.alg.indentedtree/src/org/eclipse/elk/alg/indentedtree/IndentedtreeLayoutProvider.java
Show resolved
Hide resolved
plugins/org.eclipse.elk.alg.indentedtree/src/org/eclipse/elk/alg/indentedtree/indentedtree.melk
Show resolved
Hide resolved
plugins/org.eclipse.elk.alg.indentedtree/src/org/eclipse/elk/alg/indentedtree/indentedtree.melk
Outdated
Show resolved
Hide resolved
...se.elk.alg.indentedtree/src/org/eclipse/elk/alg/indentedtree/options/InternalProperties.java
Outdated
Show resolved
Hide resolved
...se.elk.alg.indentedtree/src/org/eclipse/elk/alg/indentedtree/options/InternalProperties.java
Outdated
Show resolved
Hide resolved
copyright headers, newlines, removed .gitignore from src-gen/ folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the IndentedTree layout algorithm for filesystem-like representations of trees without ports.
Currently, this involves a recursive depth-first-search to obtain a list of nodes ordered by parent-child relationship.
This might leave room for improvement.