Skip to content

Commit

Permalink
#140 Update to emfcloud.checkstyle 0.1.0-RC02 (#141)
Browse files Browse the repository at this point in the history
* #140 Update to emfcloud.checkstyle 0.1.0-RC02

The new release candiate uses a ruleset that is compliant with Checkstyle 8.44 as default.
This ensures that the checkstyle config can also be used in the latest Eclipse Relaease (8.44).
If you don't use the latest Eclipse release it's still recommended to update to the latest eclipse-checkstyle plugin version. However, the old checkstyle config (8.39) is still available and can be set in the project-specific properties.

Fixes #140

* Add resources that changed after importing all projects via maven
  • Loading branch information
tortmayr authored Dec 7, 2021
1 parent 677931b commit 0031a44
Show file tree
Hide file tree
Showing 40 changed files with 318 additions and 86 deletions.
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,8 @@ All involved code must adhere to the provided codestyle and checkstyle settings.
- Install the Eclipse Checkstyle Plug-in via its update site `https://checkstyle.org/eclipse-cs/#!/install`.

#### Configure Checkstyle
To configure Checkstyle for the new project right click on the project, choose `Checkstyle > Configure project(s) from blueprint...` and select `org.eclipse.emfcloud.modelserver.common` as blueprint project.
This project uses the common checkstyle ruleset from EMF.cloud. Please follow the [instructions for usage in Eclipse](https://github.com/eclipse-emfcloud/emfcloud/tree/master/codestyle#usage-in-eclipse-ide) to configure this ruleset for a new project.
To configure Checkstyle for a new project in the same workspace your can also right click on the project, choose `Checkstyle > Configure project(s) from blueprint...` and select `org.eclipse.emfcloud.modelserver.common` as blueprint project.
Run `Checkstyle > Check Code with Checkstyle` to make sure Checkstyle is activated correctly.

#### Import Existing Projects
Expand Down
17 changes: 17 additions & 0 deletions bundles/.project
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<?xml version="1.0" encoding="UTF-8"?>
<projectDescription>
<name>org.eclipse.emfcloud.modelserver.bundles.parent</name>
<comment></comment>
<projects>
</projects>
<buildSpec>
<buildCommand>
<name>org.eclipse.m2e.core.maven2Builder</name>
<arguments>
</arguments>
</buildCommand>
</buildSpec>
<natures>
<nature>org.eclipse.m2e.core.maven2Nature</nature>
</natures>
</projectDescription>
2 changes: 2 additions & 0 deletions bundles/.settings/org.eclipse.core.resources.prefs
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
eclipse.preferences.version=1
encoding/<project>=UTF-8
4 changes: 4 additions & 0 deletions bundles/.settings/org.eclipse.m2e.core.prefs
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
activeProfiles=
eclipse.preferences.version=1
resolveWorkspaceProjects=true
version=1
16 changes: 11 additions & 5 deletions bundles/org.eclipse.emfcloud.modelserver.client/.checkstyle
Original file line number Diff line number Diff line change
@@ -1,12 +1,18 @@
<?xml version="1.0" encoding="UTF-8"?>

<fileset-config file-format-version="1.2.0" simple-config="true" sync-formatter="false">
<local-check-config name="EMF.cloud Checkstyle" location="https://raw.githubusercontent.com/eclipse-emfcloud/emfcloud/master/codestyle/org.eclipse.emfcloud.checkstyle/src/main/resources/emfcloud-checkstyle.xml" type="remote" description="The central checkstyle configuration for emfcloud">
<additional-data name="cache-props-file-location" value="EMFcloud Checkstyle_1618908540765_cache.properties"/>
<fileset-config file-format-version="1.2.0" simple-config="false" sync-formatter="false">
<local-check-config name="EMF.cloud Checkstyle (8.39)" location="https://raw.githubusercontent.com/eclipse-emfcloud/emfcloud/master/codestyle/org.eclipse.emfcloud.checkstyle/src/main/resources/emfcloud-checkstyle-8.39.xml" type="remote" description="The central checkstyle configuration for EMF.cloud Checkstyle Version 8.39">
<additional-data name="cache-props-file-location" value="EMF.cloud Checkstyle (8.39)_1638214328569_cache.properties"/>
<additional-data name="cache-file-location" value="EMF.cloud Checkstyle (8.39)_1638214328569_cache.xml"/>
<additional-data name="cache-file" value="true"/>
<additional-data name="cache-file-location" value="EMFcloud Checkstyle_1618908540765_cache.xml"/>
</local-check-config>
<fileset name="all" enabled="true" check-config-name="EMF.cloud Checkstyle" local="true">
<local-check-config name="EMF.cloud Checkstyle (8.44)" location="https://raw.githubusercontent.com/eclipse-emfcloud/emfcloud/master/codestyle/org.eclipse.emfcloud.checkstyle/src/main/resources/emfcloud-checkstyle-8.44.xml" type="remote" description="The central checkstyle configuration for EMF.cloud Checkstyle Version 8.44">
<additional-data name="cache-props-file-location" value="EMF.cloud Checkstyle (8.44)_1638214295838_cache.properties"/>
<additional-data name="cache-file-location" value="EMF.cloud Checkstyle (8.44)_1638214295838_cache.xml"/>
<additional-data name="cache-file" value="true"/>
</local-check-config>
<fileset name="all non-generated" enabled="true" check-config-name="EMF.cloud Checkstyle (8.44)" local="true">
<file-match-pattern match-pattern="." include-pattern="true"/>
<file-match-pattern match-pattern="src-gen" include-pattern="false"/>
</fileset>
</fileset-config>
16 changes: 11 additions & 5 deletions bundles/org.eclipse.emfcloud.modelserver.common/.checkstyle
Original file line number Diff line number Diff line change
@@ -1,12 +1,18 @@
<?xml version="1.0" encoding="UTF-8"?>

<fileset-config file-format-version="1.2.0" simple-config="true" sync-formatter="false">
<local-check-config name="EMF.cloud Checkstyle" location="https://raw.githubusercontent.com/eclipse-emfcloud/emfcloud/master/codestyle/org.eclipse.emfcloud.checkstyle/src/main/resources/emfcloud-checkstyle.xml" type="remote" description="The central checkstyle configuration for emfcloud">
<additional-data name="cache-props-file-location" value="EMFcloud Checkstyle_1618908540765_cache.properties"/>
<fileset-config file-format-version="1.2.0" simple-config="false" sync-formatter="false">
<local-check-config name="EMF.cloud Checkstyle (8.39)" location="https://raw.githubusercontent.com/eclipse-emfcloud/emfcloud/master/codestyle/org.eclipse.emfcloud.checkstyle/src/main/resources/emfcloud-checkstyle-8.39.xml" type="remote" description="The central checkstyle configuration for EMF.cloud Checkstyle Version 8.39">
<additional-data name="cache-props-file-location" value="EMF.cloud Checkstyle (8.39)_1638214328569_cache.properties"/>
<additional-data name="cache-file-location" value="EMF.cloud Checkstyle (8.39)_1638214328569_cache.xml"/>
<additional-data name="cache-file" value="true"/>
<additional-data name="cache-file-location" value="EMFcloud Checkstyle_1618908540765_cache.xml"/>
</local-check-config>
<fileset name="all" enabled="true" check-config-name="EMF.cloud Checkstyle" local="true">
<local-check-config name="EMF.cloud Checkstyle (8.44)" location="https://raw.githubusercontent.com/eclipse-emfcloud/emfcloud/master/codestyle/org.eclipse.emfcloud.checkstyle/src/main/resources/emfcloud-checkstyle-8.44.xml" type="remote" description="The central checkstyle configuration for EMF.cloud Checkstyle Version 8.44">
<additional-data name="cache-props-file-location" value="EMF.cloud Checkstyle (8.44)_1638214295838_cache.properties"/>
<additional-data name="cache-file-location" value="EMF.cloud Checkstyle (8.44)_1638214295838_cache.xml"/>
<additional-data name="cache-file" value="true"/>
</local-check-config>
<fileset name="all non-generated" enabled="true" check-config-name="EMF.cloud Checkstyle (8.44)" local="true">
<file-match-pattern match-pattern="." include-pattern="true"/>
<file-match-pattern match-pattern="src-gen" include-pattern="false"/>
</fileset>
</fileset-config>
16 changes: 11 additions & 5 deletions bundles/org.eclipse.emfcloud.modelserver.edit/.checkstyle
Original file line number Diff line number Diff line change
@@ -1,12 +1,18 @@
<?xml version="1.0" encoding="UTF-8"?>

<fileset-config file-format-version="1.2.0" simple-config="true" sync-formatter="false">
<local-check-config name="EMF.cloud Checkstyle" location="https://raw.githubusercontent.com/eclipse-emfcloud/emfcloud/master/codestyle/org.eclipse.emfcloud.checkstyle/src/main/resources/emfcloud-checkstyle.xml" type="remote" description="The central checkstyle configuration for emfcloud">
<additional-data name="cache-props-file-location" value="EMFcloud Checkstyle_1618908540765_cache.properties"/>
<fileset-config file-format-version="1.2.0" simple-config="false" sync-formatter="false">
<local-check-config name="EMF.cloud Checkstyle (8.39)" location="https://raw.githubusercontent.com/eclipse-emfcloud/emfcloud/master/codestyle/org.eclipse.emfcloud.checkstyle/src/main/resources/emfcloud-checkstyle-8.39.xml" type="remote" description="The central checkstyle configuration for EMF.cloud Checkstyle Version 8.39">
<additional-data name="cache-props-file-location" value="EMF.cloud Checkstyle (8.39)_1638214328569_cache.properties"/>
<additional-data name="cache-file-location" value="EMF.cloud Checkstyle (8.39)_1638214328569_cache.xml"/>
<additional-data name="cache-file" value="true"/>
<additional-data name="cache-file-location" value="EMFcloud Checkstyle_1618908540765_cache.xml"/>
</local-check-config>
<fileset name="all" enabled="true" check-config-name="EMF.cloud Checkstyle" local="true">
<local-check-config name="EMF.cloud Checkstyle (8.44)" location="https://raw.githubusercontent.com/eclipse-emfcloud/emfcloud/master/codestyle/org.eclipse.emfcloud.checkstyle/src/main/resources/emfcloud-checkstyle-8.44.xml" type="remote" description="The central checkstyle configuration for EMF.cloud Checkstyle Version 8.44">
<additional-data name="cache-props-file-location" value="EMF.cloud Checkstyle (8.44)_1638214295838_cache.properties"/>
<additional-data name="cache-file-location" value="EMF.cloud Checkstyle (8.44)_1638214295838_cache.xml"/>
<additional-data name="cache-file" value="true"/>
</local-check-config>
<fileset name="all non-generated" enabled="true" check-config-name="EMF.cloud Checkstyle (8.44)" local="true">
<file-match-pattern match-pattern="." include-pattern="true"/>
<file-match-pattern match-pattern="src-gen" include-pattern="false"/>
</fileset>
</fileset-config>
16 changes: 11 additions & 5 deletions bundles/org.eclipse.emfcloud.modelserver.emf/.checkstyle
Original file line number Diff line number Diff line change
@@ -1,12 +1,18 @@
<?xml version="1.0" encoding="UTF-8"?>

<fileset-config file-format-version="1.2.0" simple-config="true" sync-formatter="false">
<local-check-config name="EMF.cloud Checkstyle" location="https://raw.githubusercontent.com/eclipse-emfcloud/emfcloud/master/codestyle/org.eclipse.emfcloud.checkstyle/src/main/resources/emfcloud-checkstyle.xml" type="remote" description="The central checkstyle configuration for emfcloud">
<additional-data name="cache-props-file-location" value="EMFcloud Checkstyle_1618908540765_cache.properties"/>
<fileset-config file-format-version="1.2.0" simple-config="false" sync-formatter="false">
<local-check-config name="EMF.cloud Checkstyle (8.39)" location="https://raw.githubusercontent.com/eclipse-emfcloud/emfcloud/master/codestyle/org.eclipse.emfcloud.checkstyle/src/main/resources/emfcloud-checkstyle-8.39.xml" type="remote" description="The central checkstyle configuration for EMF.cloud Checkstyle Version 8.39">
<additional-data name="cache-props-file-location" value="EMF.cloud Checkstyle (8.39)_1638214328569_cache.properties"/>
<additional-data name="cache-file-location" value="EMF.cloud Checkstyle (8.39)_1638214328569_cache.xml"/>
<additional-data name="cache-file" value="true"/>
<additional-data name="cache-file-location" value="EMFcloud Checkstyle_1618908540765_cache.xml"/>
</local-check-config>
<fileset name="all" enabled="true" check-config-name="EMF.cloud Checkstyle" local="true">
<local-check-config name="EMF.cloud Checkstyle (8.44)" location="https://raw.githubusercontent.com/eclipse-emfcloud/emfcloud/master/codestyle/org.eclipse.emfcloud.checkstyle/src/main/resources/emfcloud-checkstyle-8.44.xml" type="remote" description="The central checkstyle configuration for EMF.cloud Checkstyle Version 8.44">
<additional-data name="cache-props-file-location" value="EMF.cloud Checkstyle (8.44)_1638214295838_cache.properties"/>
<additional-data name="cache-file-location" value="EMF.cloud Checkstyle (8.44)_1638214295838_cache.xml"/>
<additional-data name="cache-file" value="true"/>
</local-check-config>
<fileset name="all non-generated" enabled="true" check-config-name="EMF.cloud Checkstyle (8.44)" local="true">
<file-match-pattern match-pattern="." include-pattern="true"/>
<file-match-pattern match-pattern="src-gen" include-pattern="false"/>
</fileset>
</fileset-config>
16 changes: 11 additions & 5 deletions bundles/org.eclipse.emfcloud.modelserver.lib/.checkstyle
Original file line number Diff line number Diff line change
@@ -1,12 +1,18 @@
<?xml version="1.0" encoding="UTF-8"?>

<fileset-config file-format-version="1.2.0" simple-config="true" sync-formatter="false">
<local-check-config name="EMF.cloud Checkstyle" location="https://raw.githubusercontent.com/eclipse-emfcloud/emfcloud/master/codestyle/org.eclipse.emfcloud.checkstyle/src/main/resources/emfcloud-checkstyle.xml" type="remote" description="The central checkstyle configuration for emfcloud">
<additional-data name="cache-props-file-location" value="EMFcloud Checkstyle_1618908540765_cache.properties"/>
<fileset-config file-format-version="1.2.0" simple-config="false" sync-formatter="false">
<local-check-config name="EMF.cloud Checkstyle (8.39)" location="https://raw.githubusercontent.com/eclipse-emfcloud/emfcloud/master/codestyle/org.eclipse.emfcloud.checkstyle/src/main/resources/emfcloud-checkstyle-8.39.xml" type="remote" description="The central checkstyle configuration for EMF.cloud Checkstyle Version 8.39">
<additional-data name="cache-props-file-location" value="EMF.cloud Checkstyle (8.39)_1638214328569_cache.properties"/>
<additional-data name="cache-file-location" value="EMF.cloud Checkstyle (8.39)_1638214328569_cache.xml"/>
<additional-data name="cache-file" value="true"/>
<additional-data name="cache-file-location" value="EMFcloud Checkstyle_1618908540765_cache.xml"/>
</local-check-config>
<fileset name="all" enabled="true" check-config-name="EMF.cloud Checkstyle" local="true">
<local-check-config name="EMF.cloud Checkstyle (8.44)" location="https://raw.githubusercontent.com/eclipse-emfcloud/emfcloud/master/codestyle/org.eclipse.emfcloud.checkstyle/src/main/resources/emfcloud-checkstyle-8.44.xml" type="remote" description="The central checkstyle configuration for EMF.cloud Checkstyle Version 8.44">
<additional-data name="cache-props-file-location" value="EMF.cloud Checkstyle (8.44)_1638214295838_cache.properties"/>
<additional-data name="cache-file-location" value="EMF.cloud Checkstyle (8.44)_1638214295838_cache.xml"/>
<additional-data name="cache-file" value="true"/>
</local-check-config>
<fileset name="all non-generated" enabled="true" check-config-name="EMF.cloud Checkstyle (8.44)" local="true">
<file-match-pattern match-pattern="." include-pattern="true"/>
<file-match-pattern match-pattern="src-gen" include-pattern="false"/>
</fileset>
</fileset-config>
4 changes: 2 additions & 2 deletions bundles/org.eclipse.emfcloud.modelserver.lib/.classpath
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<classpath>
<classpathentry exported="true" kind="lib" path="lib/websocket-api-9.4.43.v20210629.jar"/>
<classpathentry exported="true" kind="lib" path="lib/websocket-servlet-9.4.43.v20210629.jar"/>
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-11">
<attributes>
<attribute name="module" value="true"/>
Expand All @@ -15,5 +13,7 @@
<classpathentry exported="true" kind="lib" path="lib/kotlin-stdlib-common-1.4.10.jar" sourcepath="lib/kotlin-stdlib-common-1.4.10-sources.jar"/>
<classpathentry exported="true" kind="lib" path="lib/okhttp-4.9.0.jar" sourcepath="lib/okhttp-4.9.0-sources.jar"/>
<classpathentry exported="true" kind="lib" path="lib/okio-2.10.0.jar" sourcepath="lib/okio-2.10.0-sources.jar"/>
<classpathentry exported="true" kind="lib" path="lib/websocket-api-9.4.43.v20210629.jar"/>
<classpathentry exported="true" kind="lib" path="lib/websocket-servlet-9.4.43.v20210629.jar"/>
<classpathentry kind="output" path="target/classes"/>
</classpath>
6 changes: 6 additions & 0 deletions bundles/org.eclipse.emfcloud.modelserver.lib/.project
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@
<arguments>
</arguments>
</buildCommand>
<buildCommand>
<name>net.sf.eclipsecs.core.CheckstyleBuilder</name>
<arguments>
</arguments>
</buildCommand>
<buildCommand>
<name>org.eclipse.m2e.core.maven2Builder</name>
<arguments>
Expand All @@ -30,5 +35,6 @@
<nature>org.eclipse.m2e.core.maven2Nature</nature>
<nature>org.eclipse.pde.PluginNature</nature>
<nature>org.eclipse.jdt.core.javanature</nature>
<nature>net.sf.eclipsecs.core.CheckstyleNature</nature>
</natures>
</projectDescription>
17 changes: 17 additions & 0 deletions examples/.project
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<?xml version="1.0" encoding="UTF-8"?>
<projectDescription>
<name>org.eclipse.emfcloud.modelserver.examples.parent</name>
<comment></comment>
<projects>
</projects>
<buildSpec>
<buildCommand>
<name>org.eclipse.m2e.core.maven2Builder</name>
<arguments>
</arguments>
</buildCommand>
</buildSpec>
<natures>
<nature>org.eclipse.m2e.core.maven2Nature</nature>
</natures>
</projectDescription>
2 changes: 2 additions & 0 deletions examples/.settings/org.eclipse.core.resources.prefs
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
eclipse.preferences.version=1
encoding/<project>=UTF-8
4 changes: 4 additions & 0 deletions examples/.settings/org.eclipse.m2e.core.prefs
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
activeProfiles=
eclipse.preferences.version=1
resolveWorkspaceProjects=true
version=1
16 changes: 11 additions & 5 deletions examples/org.eclipse.emfcloud.modelserver.coffee.model/.checkstyle
Original file line number Diff line number Diff line change
@@ -1,12 +1,18 @@
<?xml version="1.0" encoding="UTF-8"?>

<fileset-config file-format-version="1.2.0" simple-config="true" sync-formatter="false">
<local-check-config name="EMF.cloud Checkstyle" location="https://raw.githubusercontent.com/eclipse-emfcloud/emfcloud/master/codestyle/org.eclipse.emfcloud.checkstyle/src/main/resources/emfcloud-checkstyle.xml" type="remote" description="The central checkstyle configuration for emfcloud">
<additional-data name="cache-props-file-location" value="EMFcloud Checkstyle_1618908540765_cache.properties"/>
<fileset-config file-format-version="1.2.0" simple-config="false" sync-formatter="false">
<local-check-config name="EMF.cloud Checkstyle (8.39)" location="https://raw.githubusercontent.com/eclipse-emfcloud/emfcloud/master/codestyle/org.eclipse.emfcloud.checkstyle/src/main/resources/emfcloud-checkstyle-8.39.xml" type="remote" description="The central checkstyle configuration for EMF.cloud Checkstyle Version 8.39">
<additional-data name="cache-props-file-location" value="EMF.cloud Checkstyle (8.39)_1638214328569_cache.properties"/>
<additional-data name="cache-file-location" value="EMF.cloud Checkstyle (8.39)_1638214328569_cache.xml"/>
<additional-data name="cache-file" value="true"/>
<additional-data name="cache-file-location" value="EMFcloud Checkstyle_1618908540765_cache.xml"/>
</local-check-config>
<fileset name="all" enabled="true" check-config-name="EMF.cloud Checkstyle" local="true">
<local-check-config name="EMF.cloud Checkstyle (8.44)" location="https://raw.githubusercontent.com/eclipse-emfcloud/emfcloud/master/codestyle/org.eclipse.emfcloud.checkstyle/src/main/resources/emfcloud-checkstyle-8.44.xml" type="remote" description="The central checkstyle configuration for EMF.cloud Checkstyle Version 8.44">
<additional-data name="cache-props-file-location" value="EMF.cloud Checkstyle (8.44)_1638214295838_cache.properties"/>
<additional-data name="cache-file-location" value="EMF.cloud Checkstyle (8.44)_1638214295838_cache.xml"/>
<additional-data name="cache-file" value="true"/>
</local-check-config>
<fileset name="all non-generated" enabled="true" check-config-name="EMF.cloud Checkstyle (8.44)" local="true">
<file-match-pattern match-pattern="." include-pattern="true"/>
<file-match-pattern match-pattern="src-gen" include-pattern="false"/>
</fileset>
</fileset-config>
Loading

0 comments on commit 0031a44

Please sign in to comment.