Fix MQTT5 Connect Reason Codes #3663
Merged
+1,263
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophokles73
force-pushed
the
fix_mqtt5_reason_codes
branch
from
eb04b19
to
a50dc65
Compare
sophokles73
force-pushed
the
fix_mqtt5_reason_codes
branch
from
a50dc65
to
a851b56
Compare
|
@mattkaem would you mind taking a look? |
sure, I will have a look |
mattkaem
reviewed
Nov 21, 2024
...-base/src/main/java/org/eclipse/hono/adapter/mqtt/AbstractVertxBasedMqttProtocolAdapter.java
Show resolved
Hide resolved
|
@mattkaem any additional questions? |
MQTT5 defines new reason codes to be included in CONNACK packets when connection establishment fails. The abstract adapter base class has been changed accordingly. Also added integration tests based on HiveMQ client for testing connection establishment.
sophokles73
force-pushed
the
fix_mqtt5_reason_codes
branch
from
a851b56
to
cd163d4
Compare
mattkaem
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MQTT5 defines new reason codes to be included in CONNACK packets when connection establishment fails. The abstract adapter base class has been changed accordingly.
Also added integration tests based on HiveMQ client for testing connection establishment.
Addresses #2955