-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#2301 Mixed mode 32 and 64 bit #2348
iox-#2301 Mixed mode 32 and 64 bit #2348
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2348 +/- ##
==========================================
- Coverage 83.61% 78.33% -5.29%
==========================================
Files 433 439 +6
Lines 16033 16162 +129
Branches 2299 2314 +15
==========================================
- Hits 13406 12660 -746
- Misses 2627 2652 +25
- Partials 0 850 +850
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ee1a926
to
d3182ac
Compare
8905676
to
cdf6ca0
Compare
cdf6ca0
to
2d7c8d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides of some minor spelling mistakes and a code question everything looks fine.
Notes for Reviewer
This PR enables to connect 32 and 64 bit applications to have zero-copy communication. It is currently a technology preview based on spin locks and spin semaphores as replacement for their POSIX counterpart. For production, these contructs need to be based on futex on Linux and WaitOnAddress on Windows. For other OSes, solutions need to be found as well.
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References