Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#2364 Fix Bzlmod module name typo #2363

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Conversation

lalten
Copy link
Contributor

@lalten lalten commented Oct 17, 2024

Notes for Reviewer

Currently if you want to depend on Iceoryx as a Bzlmod bazel_dep you have to do something like

bazel_dep(name = "org_eclipse_iceroyx", repo_name = "iceoryx")
git_override(
    module_name = "org_eclipse_iceroyx",
    commit = "00c5349eabfb1bce5db46efefb39fd9471679be1",
    patches = ["//third_party/iceoryx:iceoryx.patch"],
    remote = "https://github.com/eclipse-iceoryx/iceoryx",
)

It would be nice to fix that typo.

I'll send some follow up PRs to contribute patches that make depending on the module via Bzlmod actually work.

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elfenpiff
Copy link
Contributor

@lalten Thanks for the contribution. Since we are an open source project under the eclipse foundation you need to sign the ECA: https://www.eclipse.org/legal/eca/

We are targeting mission-critical systems and this requires that every change in the repo must be connected to an issue. So could you please create an issue.

Also every commit must have the prefix iox-#??? where ??? is the issue number.

@lalten
Copy link
Contributor Author

lalten commented Oct 17, 2024

@elfenpiff please have another look.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.71%. Comparing base (fc86354) to head (3978c63).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2363      +/-   ##
==========================================
+ Coverage   78.69%   78.71%   +0.01%     
==========================================
  Files         440      440              
  Lines       16981    16981              
  Branches     2361     2361              
==========================================
+ Hits        13364    13366       +2     
+ Misses       2736     2735       -1     
+ Partials      881      880       -1     
Flag Coverage Δ
unittests 78.51% <ø> (+0.01%) ⬆️
unittests_timing 15.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@elfenpiff
Copy link
Contributor

@lalten Looks good. I created this issue #2364 for you. Could you please adjust your commit message so that the prefix is iox-#2364 - then we can merge this PR.

@elfenpiff elfenpiff self-requested a review October 17, 2024 17:34
@lalten lalten force-pushed the patch-1 branch 2 times, most recently from 2f2d0cb to cc1cf75 Compare October 18, 2024 10:28
@lalten lalten changed the title Fix Bzlmod module name typo iox-#2364 Fix Bzlmod module name typo Oct 21, 2024
@lalten
Copy link
Contributor Author

lalten commented Oct 21, 2024

@elfenpiff anything left to do on my side for this PR?

@elBoberido
Copy link
Member

@lalten can you please rebase? We deactivated the Cirrus CI on main since we ran out of credits for the open source project.

@elBoberido elBoberido merged commit aa13b0a into eclipse-iceoryx:main Oct 29, 2024
21 of 22 checks passed
@elBoberido
Copy link
Member

@lalten thanks for your contribution and sorry letting you wait so long with the merge :)

@lalten lalten deleted the patch-1 branch October 29, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Bazel Typo
3 participants