-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#2364 Fix Bzlmod module name typo #2363
Conversation
@lalten Thanks for the contribution. Since we are an open source project under the eclipse foundation you need to sign the ECA: https://www.eclipse.org/legal/eca/ We are targeting mission-critical systems and this requires that every change in the repo must be connected to an issue. So could you please create an issue. Also every commit must have the prefix |
@elfenpiff please have another look. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2363 +/- ##
==========================================
+ Coverage 78.69% 78.71% +0.01%
==========================================
Files 440 440
Lines 16981 16981
Branches 2361 2361
==========================================
+ Hits 13364 13366 +2
+ Misses 2736 2735 -1
+ Partials 881 880 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
2f2d0cb
to
cc1cf75
Compare
@elfenpiff anything left to do on my side for this PR? |
@lalten can you please rebase? We deactivated the Cirrus CI on main since we ran out of credits for the open source project. |
@lalten thanks for your contribution and sorry letting you wait so long with the merge :) |
Notes for Reviewer
Currently if you want to depend on Iceoryx as a Bzlmod bazel_dep you have to do something like
It would be nice to fix that typo.
I'll send some follow up PRs to contribute patches that make depending on the module via Bzlmod actually work.
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References