Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#2377: Include <chrono> for system_clock #2378

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LilyWangLL
Copy link

Notes for Reviewer

I am a member of Microsoft vcpkg, due to there are new changes merged by microsoft/STL#5105, which revealed a conformance issue in iceoryx. It must add include <chrono> to fix this error.

Compiler error with this STL change:

D:\b\iceoryx\src\v2.0.6-c8abea20ae.clean\iceoryx_platform\win\source\time.cpp(42): error C2039: 'system_clock': is not a member of 'std::chrono'

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@LilyWangLL LilyWangLL mentioned this pull request Nov 28, 2024
21 tasks
@LilyWangLL
Copy link
Author

LilyWangLL commented Nov 28, 2024

Pinging @elfenpiff ...

I have signed the ECA, but I don't know why this PR show failed with the ECA check. Please let me know what I should do about this. Thanks in advance.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix windows performance issue
1 participant