Fix line number mismatch during stack trace navigation from Open Type window #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
window eclipse-jdt#617 This commit resolves the issue where the line numbers were mis-aligned (n-1) when navigating through a stack trace via the Open Type window. The fix ensures proper synchronization of line numbers, providing an accurate navigation experience. Fixes : eclipse-jdt#617
|
@iloveeclipse this will fix the issue, but unfortunately I couldn't find any related test to refer navigating from Open type window. |
...lipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/console/JavaStackTraceHyperlink.java
Show resolved
Hide resolved
|
Build is complete. Please merge. |
|
Thank you @iloveeclipse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#617
This commit resolves the issue where the line numbers were mis-aligned (n-1) when navigating through a stack trace via the Open Type window. The fix ensures proper synchronization of line numbers, providing an accurate navigation experience.
Fixes : #617
What it does
How to test
Author checklist