Correct enumeration of tests when running tests from a folder (#920)

[erik-brangs]

What it does

Currently, when running tests from a source folder with JUnit 5, all tests that share a package with those packages in the selected source folder will be run (see #920). This attempts to fix this by enumerating all tests as suggested in #920.

I don't know if JDT uses a mocking framework so I mocked the needed classes by hand.

How to test

I've added a test case. I'm not sure if that is sufficient.

Author checklist

• I have thoroughly tested my changes
• The change is following the coding conventions
• I have signed the Eclipse Contributor Agreement (ECA)

Edit: I've added a few more tests so I've set the checkmark for through testing.

[jukzi]

i have not looked into the details. but please do remove all "TODO"s
also there alsoready is a MockLaunch
org.eclipse.jdt.debug.tests.connectors.MockLaunch, please choose another name. Also it would be good to somehow have less boiler plate code - maybe extend Launch like NoopLaunch?

[erik-brangs]

Thank you. I've changed the code to use Launch which seems to work fine for the test cases.

[jukzi]

the test is not executed on jenkins. please reference it to be executed
https://ci.eclipse.org/jdt/job/eclipse.jdt.ui-github/job/PR-1066/3/consoleText

[erik-brangs]

I've changed the test to JUnit 4 and added a suite.

[jukzi]

jenkins test fail with

java.lang.AssertionError: The declared package "" does not match the expected package "p1". Actual: 2
	at org.eclipse.jdt.ui.tests.jarexport.FatJarExportTests.buildProject(FatJarExportTests.java:314)
	at org.eclipse.jdt.ui.tests.jarexport.FatJarExportTests.assertFatJarExport(FatJarExportTests.java:205)
	at org.eclipse.jdt.ui.tests.jarexport.FatJarExportTests.createAndRunFatJar(FatJarExportTests.java:175)
	at org.eclipse.jdt.ui.tests.jarexport.FatJarExportTests.exportExternalLib(FatJarExportTests.java:876)

please fix

[jukzi]

i rebased the commit to master, to get the tests running. just ping me if should forget to review the result

[erik-brangs]

@jukzi The tests have completed, please review

[jukzi]

ok, tests are run and don't fail:

[2024-02-02T09:05:10.728Z] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.419 s -- in AutomatedSuite org.eclipse.jdt.junit.launcher.JUnitLauncherTests org.eclipse.jdt.junit.launcher.AdvancedJUnitLaunchConfigurationDelegateTest
[2024-02-02T09:05:10.728Z] org.eclipse.jdt.junit.launcher.AdvancedJUnitLaunchConfigurationDelegateTest.runTestsInSourceFolderOnlyUsesTopLevelClasses -- Time elapsed: 0.176 s
[2024-02-02T09:05:10.729Z] org.eclipse.jdt.junit.launcher.AdvancedJUnitLaunchConfigurationDelegateTest.runTestsInSourceFolderHandlesMultiplePackagesInASourceFolderCorrectly -- Time elapsed: 0.090 s
[2024-02-02T09:05:10.729Z] org.eclipse.jdt.junit.launcher.AdvancedJUnitLaunchConfigurationDelegateTest.runTestsInSourceFolderHandlesMultipleSourceFoldersCorrectly -- Time elapsed: 0.085 s
[2024-02-02T09:05:10.729Z] org.eclipse.jdt.junit.launcher.AdvancedJUnitLaunchConfigurationDelegateTest.runTestsInSourceFolderHandlesMultipleSourceFilesInPackagesInASourceFolderCorrectly -- Time elapsed: 0.068 s

[jukzi]

@Bananeweizen can you please review, as you have created the issue - does it solve your issue?

comment removed

[jukzi]

@Bananeweizen ping

[erik-brangs]

@jukzi Can this go in for 2024-06 or do I still need to do something?

[jukzi]

the reported API errors are unrelated and i don't know why they are shown as new here

[iloveeclipse]

the reported API errors are unrelated and i don't know why they are shown as new here

Is the commit based on master head?

[Bananeweizen]

Sorry for completely missing the notifications here. That looks good to me. Thanks a lot for the change!

[iloveeclipse]

It seems this PR caused regression, please check: #1651

[erik-brangs]

I'll take a look but I can't say when. I have unreliable internet access at the moment. I don't know when I'll next have access that is good enough to do any work.