[WIP] Allow multiple jdk registration for one runtime environment #3107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sheng Chen <[email protected]>
jdneo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to fix redhat-developer/vscode-java#2115
Basically, this PR allows to register multiple jdks for the same environment. And the first registered one will become the default jdk for that runtime environment.
Then user can switch jdks for the same runtime environment in the classpath configuration webview.
Moreover, when some jdks are missed by the jdk detection, user can manually add them, the webview can persist them in the global
java.configuration.runtimes, then all other workspaces will automatically have those added jdks via the settings.@rgrunber Please let me know your thoughts/concerns about this change