Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address bug in check-markdown-link #12

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

erikbosch
Copy link
Contributor

It currently gives an error for links containing %2F, like:

https://github.com/eclipse-kuksa/kuksa-python-sdk/pkgs/container/kuksa-python-sdk%2Fkuksa-client

Probably same error as reported in tcort/markdown-link-check#264

Proposed workaround is to exclude links with % from check

It currently gives an error for links containing %2F, like:

https://github.com/eclipse-kuksa/kuksa-python-sdk/pkgs/container/kuksa-python-sdk%2Fkuksa-client

Probably same error as reported in tcort/markdown-link-check#264

Proposed workaround is to exclude links with % from check
Copy link
Contributor

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This thing is pretty buggy :D Let's see how many exceptions we will need.

lgtm 😶‍🌫️

@SebastianSchildt SebastianSchildt merged commit 2d3ac48 into eclipse-kuksa:main Jun 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants