Skip to content

Commit

Permalink
Fix builds on MacOS ARM64 with Java 8 (Temurin).
Browse files Browse the repository at this point in the history
- macos-latest is an arm64 runner, and  'temurin' has no support for
  this architecture on Java 8
- Force 'x64' architecture on macos-latest since Rosetta layer should
  provide necessary support

Signed-off-by: Roland Grunberg <[email protected]>
  • Loading branch information
rgrunber authored and datho7561 committed Jul 17, 2024
1 parent bb6a995 commit 1063ef0
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/pr-verify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ jobs:
with:
java-version: '8'
distribution: 'temurin'
architecture: ${{ matrix.os == 'macos-latest' && 'x64' || '' }}
cache: 'maven'
- name: Run Tests
run: ./mvnw -B '-Dlemminx.cacheInRepoDir' clean verify
run: ./mvnw -B '-Dlemminx.cacheInRepoDir' clean verify

0 comments on commit 1063ef0

Please sign in to comment.