Add an uber-bundle artifact #1701
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently lemminx only provides an uber-jar that has no OSGi meta data at all, because of this for example wild-webdeveloper needs to embed this jar instead of use one installed in the OSGi framework. This now adds a new uber-bundle artifact that is at the moment very similar to uber-jar but contains some OSGi data useful for writing extensions. This can then be used as a starting point to incrementally make it more OSGified, e.g. by export/import its dependencies that are already available as OSGi bundles (gson, lsp4j, ...) Signed-off-by: Christoph Läubrich <[email protected]>
|
As an alternative I'm currently try to make the lemminx bundle itself a bit more useful, has anyone actually using that inside OSGi environments and can tell about it more? |
|
There is now as a first starting point. |
|
I'm closing this in favor of much simpler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently lemminx only provides an uber-jar that has no OSGi meta data at all, because of this for example wild-webdeveloper needs to embed this jar instead of use one installed in the OSGi framework.
This now adds a new uber-bundle artifact that is at the moment very similar to uber-jar but contains some OSGi data useful for writing extensions. This can then be used as a starting point to incrementally make it more OSGified, e.g. by export/import its dependencies that are already available as OSGi bundles (gson, lsp4j, ...)
FYI @mickaelistria
This currently requires tycho-snapshot repository therefore I marked the PR as a draft but wanted to share current progress already.